This repository was archived by the owner on May 5, 2023. It is now read-only.
Made msiEndpoint and msiSecret optional #4417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can one of the admins verify this patch? |
ghost
added
the
ghost
self-requested a review
|
Looks good to me. Thanks for adding this! |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The options msiEndpoint and msiSecret should be optional as their are loaded from environment by default and does not have to be present to provide another options (e.g. resource). See line 35-36.
Currently I have to use it as
await msRestAzure.loginWithAppServiceMSI({ resource: "https://vault.azure.net" } as msRestAzure.MSIAppServiceTokenCredentials);