This repository was archived by the owner on May 5, 2023. It is now read-only.
Merged
Conversation
…r Metric Alert API (#3714) * Generated from 09c5415be341f2a6816dafb7a504818a3c536b7e Multi Resource Alert changes * Generated from a88d7f44fc48e9ea0c1203b6bf10bac1b65111e4 Merge remote-tracking branch 'upstream/master'
This was referenced Oct 4, 2018
Merged
ghost
assigned
ghost
self-requested a review
ghost
suggested changes
Oct 4, 2018
There was a problem hiding this comment.
This should actually be a major version change because MetricCriteria inherited a required property from MultiMetricCriteria. This will break any current MetricCriteria objects that currently exist.
ghost
approved these changes
Oct 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created to accumulate context: monitor/resource-manager