[AutoPR dns/resource-manager] Use common arm definitions for dns

lib/services/dnsManagement/lib/dnsManagementClient.d.ts

@@ -21,7 +21,7 @@ export default class DnsManagementClient extends AzureServiceClient {
    * @class
    * @param {credentials} credentials - Credentials needed for the client to connect to Azure.
    *
-   * @param {string} subscriptionId - Specifies the Azure subscription ID, which uniquely identifies the Microsoft Azure subscription.
+   * @param {string} subscriptionId - The ID of the target subscription.
    *
    * @param {string} [baseUri] - The base URI of the service.
    *

lib/services/dnsManagement/lib/dnsManagementClient.js

@@ -27,7 +27,7 @@ class DnsManagementClient extends ServiceClient {
   /**
    * Create a DnsManagementClient.
    * @param {credentials} credentials - Credentials needed for the client to connect to Azure.
-   * @param {string} subscriptionId - Specifies the Azure subscription ID, which uniquely identifies the Microsoft Azure subscription.
+   * @param {string} subscriptionId - The ID of the target subscription.
    * @param {string} [baseUri] - The base URI of the service.
    * @param {object} [options] - The parameter options
    * @param {Array} [options.filters] - Filters to be added to the request pipeline

lib/services/dnsManagement/lib/models/azureEntityResource.js

@@ -0,0 +1,82 @@
+/*
+ * Copyright (c) Microsoft Corporation. All rights reserved.
+ * Licensed under the MIT License. See License.txt in the project root for
+ * license information.
+ *
+ * Code generated by Microsoft (R) AutoRest Code Generator.
+ * Changes may cause incorrect behavior and will be lost if the code is
+ * regenerated.
+ */
+
+'use strict';
+
+const models = require('./index');
+
+/**
+ * The resource model definition for a Azure Resource Manager resource with an
+ * etag.
+ *
+ * @extends models['Resource']
+ */
+class AzureEntityResource extends models['Resource'] {
+  /**
+   * Create a AzureEntityResource.
+   * @member {string} [etag] Resource Etag.
+   */
+  constructor() {
+    super();
+  }
+
+  /**
+   * Defines the metadata of AzureEntityResource
+   *
+   * @returns {object} metadata of AzureEntityResource
+   *
+   */
+  mapper() {
+    return {
+      required: false,
+      serializedName: 'AzureEntityResource',
+      type: {
+        name: 'Composite',
+        className: 'AzureEntityResource',
+        modelProperties: {
+          id: {
+            required: false,
+            readOnly: true,
+            serializedName: 'id',
+            type: {
+              name: 'String'
+            }
+          },
+          name: {
+            required: false,
+            readOnly: true,
+            serializedName: 'name',
+            type: {
+              name: 'String'
+            }
+          },
+          type: {
+            required: false,
+            readOnly: true,
+            serializedName: 'type',
+            type: {
+              name: 'String'
+            }
+          },
+          etag: {
+            required: false,
+            readOnly: true,
+            serializedName: 'etag',
+            type: {
+              name: 'String'
+            }
+          }
+        }
+      }
+    };
+  }
+}
+
+module.exports = AzureEntityResource;

lib/services/dnsManagement/lib/models/index.d.ts

@@ -299,20 +299,30 @@ export interface SubResource {
  * @class
  * Initializes a new instance of the Resource class.
  * @constructor
- * Common properties of an Azure Resource Manager resource
- *
- * @member {string} [id] Resource ID.
- * @member {string} [name] Resource name.
- * @member {string} [type] Resource type.
- * @member {string} location Resource location.
- * @member {object} [tags] Resource tags.
+ * @member {string} [id] Fully qualified resource Id for the resource. Ex -
+ * /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/{resourceProviderNamespace}/{resourceType}/{resourceName}
+ * @member {string} [name] The name of the resource
+ * @member {string} [type] The type of the resource. Ex-
+ * Microsoft.Compute/virtualMachines or Microsoft.Storage/storageAccounts.
  */
 export interface Resource extends BaseResource {
   readonly id?: string;
   readonly name?: string;
   readonly type?: string;
-  location: string;
+}
+
+/**
+ * @class
+ * Initializes a new instance of the TrackedResource class.
+ * @constructor
+ * The resource model definition for a ARM tracked top level resource
+ *
+ * @member {object} [tags] Resource tags.
+ * @member {string} location The geo-location where the resource lives
+ */
+export interface TrackedResource extends Resource {
   tags?: { [propertyName: string]: string };
+  location: string;
 }
 
 /**
@@ -339,7 +349,7 @@ export interface Resource extends BaseResource {
  * networks that resolve records in this DNS zone. This is a only when ZoneType
  * is Private.
  */
-export interface Zone extends Resource {
+export interface Zone extends TrackedResource {
   etag?: string;
   readonly maxNumberOfRecordSets?: number;
   readonly numberOfRecordSets?: number;
@@ -361,6 +371,30 @@ export interface ZoneUpdate {
   tags?: { [propertyName: string]: string };
 }
 
+/**
+ * @class
+ * Initializes a new instance of the ProxyResource class.
+ * @constructor
+ * The resource model definition for a ARM proxy resource. It will have
+ * everything other than required location and tags
+ *
+ */
+export interface ProxyResource extends Resource {
+}
+
+/**
+ * @class
+ * Initializes a new instance of the AzureEntityResource class.
+ * @constructor
+ * The resource model definition for a Azure Resource Manager resource with an
+ * etag.
+ *
+ * @member {string} [etag] Resource Etag.
+ */
+export interface AzureEntityResource extends Resource {
+  readonly etag?: string;
+}
+
 
 /**
  * @class

lib/services/dnsManagement/lib/models/index.js

@@ -32,7 +32,10 @@ exports.RecordSet = require('./recordSet');
 exports.RecordSetUpdateParameters = require('./recordSetUpdateParameters');
 exports.SubResource = require('./subResource');
 exports.Resource = require('./resource');
+exports.TrackedResource = require('./trackedResource');
 exports.Zone = require('./zone');
 exports.ZoneUpdate = require('./zoneUpdate');
+exports.ProxyResource = require('./proxyResource');
+exports.AzureEntityResource = require('./azureEntityResource');
 exports.RecordSetListResult = require('./recordSetListResult');
 exports.ZoneListResult = require('./zoneListResult');

lib/services/dnsManagement/lib/models/proxyResource.js

@@ -0,0 +1,73 @@
+/*
+ * Copyright (c) Microsoft Corporation. All rights reserved.
+ * Licensed under the MIT License. See License.txt in the project root for
+ * license information.
+ *
+ * Code generated by Microsoft (R) AutoRest Code Generator.
+ * Changes may cause incorrect behavior and will be lost if the code is
+ * regenerated.
+ */
+
+'use strict';
+
+const models = require('./index');
+
+/**
+ * The resource model definition for a ARM proxy resource. It will have
+ * everything other than required location and tags
+ *
+ * @extends models['Resource']
+ */
+class ProxyResource extends models['Resource'] {
+  /**
+   * Create a ProxyResource.
+   */
+  constructor() {
+    super();
+  }
+
+  /**
+   * Defines the metadata of ProxyResource
+   *
+   * @returns {object} metadata of ProxyResource
+   *
+   */
+  mapper() {
+    return {
+      required: false,
+      serializedName: 'ProxyResource',
+      type: {
+        name: 'Composite',
+        className: 'ProxyResource',
+        modelProperties: {
+          id: {
+            required: false,
+            readOnly: true,
+            serializedName: 'id',
+            type: {
+              name: 'String'
+            }
+          },
+          name: {
+            required: false,
+            readOnly: true,
+            serializedName: 'name',
+            type: {
+              name: 'String'
+            }
+          },
+          type: {
+            required: false,
+            readOnly: true,
+            serializedName: 'type',
+            type: {
+              name: 'String'
+            }
+          }
+        }
+      }
+    };
+  }
+}
+
+module.exports = ProxyResource;

lib/services/dnsManagement/lib/models/resource.js

@@ -13,18 +13,17 @@
 const models = require('./index');
 
 /**
- * Common properties of an Azure Resource Manager resource
- *
+ * Class representing a Resource.
  * @extends models['BaseResource']
  */
 class Resource extends models['BaseResource'] {
   /**
    * Create a Resource.
-   * @member {string} [id] Resource ID.
-   * @member {string} [name] Resource name.
-   * @member {string} [type] Resource type.
-   * @member {string} location Resource location.
-   * @member {object} [tags] Resource tags.
+   * @member {string} [id] Fully qualified resource Id for the resource. Ex -
+   * /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/{resourceProviderNamespace}/{resourceType}/{resourceName}
+   * @member {string} [name] The name of the resource
+   * @member {string} [type] The type of the resource. Ex-
+   * Microsoft.Compute/virtualMachines or Microsoft.Storage/storageAccounts.
    */
   constructor() {
     super();
@@ -67,27 +66,6 @@ class Resource extends models['BaseResource'] {
             type: {
               name: 'String'
             }
-          },
-          location: {
-            required: true,
-            serializedName: 'location',
-            type: {
-              name: 'String'
-            }
-          },
-          tags: {
-            required: false,
-            serializedName: 'tags',
-            type: {
-              name: 'Dictionary',
-              value: {
-                  required: false,
-                  serializedName: 'StringElementType',
-                  type: {
-                    name: 'String'
-                  }
-              }
-            }
           }
         }
       }