Conversation
|
Can one of the admins verify this patch? |
| "Srinivasan, Vivek <visriniv@microsoft.com>" | ||
| ], | ||
| "version": "3.1.1-preview", | ||
| "version": "3.2.1-preview", |
There was a problem hiding this comment.
Since the API version changed, please do a major version bump. I also think we can remove the -preview suffix.
Also, did you update the version number in the azure-rest-api-specs repository too?
There was a problem hiding this comment.
Major version bump seems good--haven't changed anything in rest-api-specs. The automation there is also broken for mystery reasons which is why I manually opened this PR.
There was a problem hiding this comment.
Major version bump seems good--haven't changed anything in rest-api-specs. The automation there is also broken for mystery reasons which is why I manually opened this PR.
The changes in the policy SDK are pretty significant. I don't know how versioning is done for this SDK, but my REST changes were to add a new [non-preview] API version for policy, so that should be reflected here using whatever versioning scheme is appropriate.
There was a problem hiding this comment.
Cool, I'll go with 4.0.0
Looks like my stuff is in there. Looks reasonable, at least to this non-Node.js guy. Thanks for getting these changes in! |
|
I think some Nock tests might need to be rerecorded. |
|
We've released several times since this PR (current azure-arm-compute version is 8.2.0), so this PR isn't needed anymore. Any changes that this PR was trying to generate have already been generated and published. |
@RikkiGibson: I've responded in direct email: please don't close this PR until that thread is resolved. |
|
@mentat9 I've responded to your e-mail. If that clears things up, let me know if I can close this PR. |
|
@mentat9 I noticed that you closed your most recent azure-rest-api-specs PR. Does that mean that I can close this PR too? |
|
I believe we already confirmed that this change was no longer needed, because it was superseded a subsequent SDK regeneration (I never quite determined how it happened). If you think the current Node.js SDK reflects what is in the current policy swagger then, yes we can close this PR. As far as I could tell, it does. |
ghost
closed this
3 participants
Should contain changes authored by @mentat9 in Azure/azure-rest-api-specs#3032