This repository was archived by the owner on May 5, 2023. It is now read-only.
[AutoPR automation/resource-manager] Remove automation parameters from client#2535
Merged
AutorestCI merged 1 commit intorestapi_auto_automation/resource-managerfrom Mar 23, 2018
Merged
Conversation
Move automation parameters to method
amarzavery
reviewed
Mar 23, 2018
| * | ||
| */ | ||
| constructor(credentials: ServiceClientCredentials, subscriptionId: string, resourceGroupName: string, automationAccountName: string, baseUri?: string, options?: AutomationClientOptions); | ||
| constructor(credentials: ServiceClientCredentials, subscriptionId: string, baseUri?: string, options?: AzureServiceClientOptions); |
Contributor
There was a problem hiding this comment.
It is abreaking change but a good change. If the package was published before then major version should be bumped by 1.
Contributor
Author
|
This PR has been merged into #2483 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created to sync Azure/azure-rest-api-specs#2741