Skip to content
This repository was archived by the owner on May 5, 2023. It is now read-only.

Conversation

@e2tox
Copy link

@e2tox e2tox commented Jun 22, 2012

but insertEntity and updateEntity does.

add utf8 encoding to the contant type and get the correct string length from Buffer.byteLength().

all unit tests passed.
self tests passed.

@andrerod
Copy link

Hi @e2tox,

Sounds like this fix would be interesting. In order for us to look at it and merge it we have however to ask you to read our contribution guidelines and, if you're ok with it, send us the form so that you can become one of our contributors:
http://windowsazure.github.com/guidelines.html

It's a one time thing and then we can accept all your future pull requests without this hassle.

Thank you,
Andre

@andrerod
Copy link

Also, one small detail: our contributions (and ongoing development) go into dev. Could you issue the pull request against dev instead of master ? :)

Master is designed to handle released code.

Thank you,
Andre

@e2tox e2tox closed this Jun 22, 2012
@e2tox
Copy link
Author

e2tox commented Jun 22, 2012

I see. thank you

@andrerod
Copy link

We'd love to see you sign up though as we love to see external contributions ... :( It's unfortunate that we require that step ...

@e2tox
Copy link
Author

e2tox commented Jun 30, 2012

I have send the required docs to cla, do I qualified?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants