Conversation
Add node config to keyvault for Swagger to SDK
|
@schaabs - This is an automatic one that got created due to the node.js readme in the rest-api-specs repo. /cc @lusitanian |
|
Closing this pull request as we already have merged these changes in to the keyvault branch as stated above. We will eventually merge these into master from the keyvault branch. @amarzavery @lmazuel This functionality seems to be a bit different from what I've seen in the python sdk repo. The change in azure-rest-api-specs repo was merged into the keyvault_preview branch. In the python sdk this results in a PR being submitted for an analogous branch in the sdk repo restapi_auto_keyvault_preview rather than into master. In that case I was able to rebase that branch to the branch where we are developing our preview. Is this the eventual expected flow for the node repo as well or has the flow changed? |
|
Could it be related to the fact that I opened a different PR for the keyvault config that was based on azure-rest-api-specs master branch? In a way it seems weird for the base branch on azure-rest-api-specs to affect the base branch on the auto-PRs for the SDK repos, but also seems like it could be useful. |
|
BTW I pulled this down and regenerated with |
Created to accumulate context: keyvault/resource-manager