This repository was archived by the owner on May 5, 2023. It is now read-only.
Update Batch SDK to API version 2018-03-01.6.1 #2452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The swagger spec in in PR: Azure/azure-rest-api-specs#2556 |
Member
Author
|
@amarzavery Could you review my PR or add other reviewer? |
amarzavery
reviewed
Mar 10, 2018
lib/services/batch/package.json
Outdated
| "ms-rest-azure": "^2.3.3", | ||
| "underscore": "^1.8.3", | ||
| "moment": "~2.18.1", | ||
| "moment": "^2.18.1", |
Contributor
There was a problem hiding this comment.
Please change this to "^2.21.0". This will make sure we will have a version higher than 2.18.1 (2.1.8.1 has security vulnerabilities ).
Contributor
There was a problem hiding this comment.
@xingwu1 - Also update the minimum versions of ms-rest and ms-rest-azure to their latest versions ^2.3.2 and ^2.5.4 respectively.
amarzavery
reviewed
Mar 10, 2018
| "ms-rest-azure": "^2.5.4", | ||
| "underscore": "^1.8.3", | ||
| "moment": "^2.18.1", | ||
| "moment": "^2.21.1", |
Contributor
Contributor
|
@xingwu1 - The PR of ms-rest has been merged and the package has been published. |
Contributor
|
@xingwu1 - Can this PR be merged? |
xingwu1
changed the title
Member
Author
|
@amarzavery We are ready to be merged. The official swagger spec has been merged. |
This was referenced Nov 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.