Skip to content
This repository was archived by the owner on May 5, 2023. It is now read-only.

[Potential] BREAKING CHANGE: Adl object refactor#2234

Closed
ro-joowan wants to merge 6 commits intoAzure:masterfrom
ro-joowan:master
Closed

[Potential] BREAKING CHANGE: Adl object refactor#2234
ro-joowan wants to merge 6 commits intoAzure:masterfrom
ro-joowan:master

Conversation

@ro-joowan
Copy link
Copy Markdown

This PR is mapped to this Swagger change: Azure/azure-rest-api-specs#1429

  • Revised the inheritance structure and broke up objects for customer-experience clarity

  • For more details, please refer to the PR above

* This change is mapped to this PR:
Azure/azure-rest-api-specs#1429
* This change is mapped to this PR:
Azure/azure-rest-api-specs#1429

* Checking in the successful tests
* Fixing some tests due to mistakes in setting up the env
* Reverting changes to the test list file back to its original form
* Reverting the gulpfile back to its original form
@msftclas
Copy link
Copy Markdown

@ro-joowan,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@begoldsm
Copy link
Copy Markdown
Contributor

@amarzavery can you take a look at this? I know it is a huge PR, but this brings ADL for node up to date with the latest swagger.

@amarzavery
Copy link
Copy Markdown
Contributor

@begoldsm we are going to have an all up release in the coming two weeks. We have some changes in the code generator as well. Hence will generate all the sdks and publish new versions.

@amarzavery amarzavery closed this Aug 28, 2017
@ro-joowan
Copy link
Copy Markdown
Author

Hi @amarzavery, I'm just curious about the closing of this PR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants