Skip to content
This repository has been archived by the owner on May 5, 2023. It is now read-only.

AzureEnvironment type is missing properties for endpoints #2247

Closed
chrmarti opened this issue Aug 14, 2017 · 5 comments
Closed

AzureEnvironment type is missing properties for endpoints #2247

chrmarti opened this issue Aug 14, 2017 · 5 comments
Labels

Comments

@chrmarti
Copy link

This looks like an omission, aren't these properties part of the API?

@amarzavery
Copy link
Contributor

Can you provide information about the Environment and the properties that are missing?

@chrmarti
Copy link
Author

The class declaration in

export class AzureEnvironment {
shows the properties being passed as the parameters object. I assume the class should have the same properties so these can be read. Examples are: managementEndpointUrl, activeDirectoryEndpointUrl, activeDirectoryResourceId.

@amarzavery
Copy link
Contributor

Ah I see. Got your point. Will fix that in the upcoming release.
On a side note, in the actual javascript code we are adding some supported environments to the prototype of AzureEnvironment class. https://github.com/Azure/azure-sdk-for-node/blob/master/runtime/ms-rest-azure/lib/azureEnvironment.js#L156 . I was wondering how would I add those supported environments to the class definition in d.ts file.

@amarzavery amarzavery mentioned this issue Aug 19, 2017
14 tasks
@chrmarti
Copy link
Author

I think you can add static properties to do that.

amarzavery added a commit to amarzavery/azure-sdk-for-node that referenced this issue Aug 25, 2017
@amarzavery
Copy link
Contributor

This has been fixed with 2.3.0 version of ms-rest-azure.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants