Use base64 encoding when importing certificates#9998
Merged
heaths merged 4 commits intoAzure:masterfrom Feb 19, 2020
Merged
Conversation
Fixes Azure#9986 by passing the model to the request method. Fixes Azure#7893 by adding tests for merge (tests for import were added in a previous commit)
schaabs
approved these changes
Feb 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a couple of issues, including a test-only issue that made testing this difficult. Several properties (3 out of 30 total) were using base64url encoding, but need to be base64. This also uncovered a couple of other issues that will likely be fixed in separate PRs.