Skip to content

Add Aggregate Report Pipeline#9964

Merged
chidozieononiwu merged 1 commit intoAzure:masterfrom
chidozieononiwu:AgregateReportPipeline
Feb 14, 2020
Merged

Add Aggregate Report Pipeline#9964
chidozieononiwu merged 1 commit intoAzure:masterfrom
chidozieononiwu:AgregateReportPipeline

Conversation

@chidozieononiwu
Copy link
Copy Markdown
Member

Move dependency report into aggregate report pipeline.
Run dependency report using downloaded artifacts from latest successful scheduled run of the net - core pipeline.

Comment thread README.md Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: IIRC, this shows up as alternative text, so maybe spell out "Dependency Graph".

Comment thread eng/pipelines/aggregate-report.yml Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big issue, but if there's nothing Windows-specific, ubuntu-18.04 is much faster.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, AzureFileCopy is windows specific.

Comment thread eng/pipelines/aggregate-report.yml Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

succeeded() is the default condition, so these instances here and below aren't necessarily needed.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see thanks

@chidozieononiwu chidozieononiwu merged commit adf4e6f into Azure:master Feb 14, 2020
displayName: 'Download Pipeline Artifact'
inputs:
buildType: specific
project: $(TargetPipelineProjectId)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which pipeline is this pulling? Do you know if it only pulls latest successful build?

Copy link
Copy Markdown
Member Author

@chidozieononiwu chidozieononiwu Feb 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It pulls the latest successful master branch build of the net-core and downloads the artifacts called 'packages'.
I didn't use allowPartiallySucceededBuilds or allowFailedBuilds so there is not case where it should download an unsuccessful run. (Assuming tool works as advertised)

@@ -0,0 +1,48 @@
trigger: none
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both java and python have file and pipeline called aggregate-reports can you please update to match?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update the name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants