Add KeyVault.Secrets configuration extensions#9937
Merged
pakrym merged 8 commits intoAzure:masterfrom Feb 14, 2020
Merged
Conversation
pakrym
requested review from
KrzysztofCwalina,
chidozieononiwu,
danieljurek,
heaths,
mitchdenny,
schaabs,
tg-msft and
weshaggard
as code owners
heaths
approved these changes
Feb 13, 2020
| } | ||
| catch (Exception) | ||
| { | ||
| // Ignore |
Contributor
Author
There was a problem hiding this comment.
ILogger is not available in configuration providers and we didn't seem to have a problem with this before. Usually the Load method throws first and surfaces the error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an initial version of KeyVault integration package for Microsoft.Extensions.Configuration.
It's planned to re-review the API but I want to get it building.