[EventHubs] Improving Event Hubs unit tests coverage

sdk/eventhub/Azure.Messaging.EventHubs.Processor/src/EventProcessorClient.cs

@@ -952,7 +952,7 @@ private async Task RunAsync(CancellationToken cancellationToken)
                     }
                     catch (EventHubsException ex)
                     {
-                        var errorEventArgs = new ProcessErrorEventArgs(null, ex.Message, ex, cancellationToken);
+                        var errorEventArgs = new ProcessErrorEventArgs(null, ex.Message, ex.InnerException ?? ex, cancellationToken);
                         _ = OnProcessErrorAsync(errorEventArgs);
                     }
                     catch (Exception ex)
@@ -1040,7 +1040,7 @@ private async Task StartPartitionProcessingAsync(string partitionId,
                 // partition.
 
                 Logger.StartPartitionProcessingError(partitionId, ex.Message);
-                var errorEventArgs = new ProcessErrorEventArgs(null, Resources.OperationListCheckpoints, ex, cancellationToken);
+                var errorEventArgs = new ProcessErrorEventArgs(partitionId, Resources.OperationListCheckpoints, ex, cancellationToken);
                 _ = OnProcessErrorAsync(errorEventArgs);
 
                 return;

sdk/eventhub/Azure.Messaging.EventHubs.Processor/tests/Properties/AssemblyInfo.cs

@@ -1,6 +1,9 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
+using System.Runtime.CompilerServices;
 using NUnit.Framework;
 
 [assembly: Parallelizable(ParallelScope.All)]
+
+[assembly: InternalsVisibleTo("DynamicProxyGenAssembly2, PublicKey=0024000004800000940000000602000000240000525341310004000001000100c547cac37abd99c8db225ef2f6c8a3602f3b3606cc9891605d02baa56104f4cfc0734aa39b93bf7852f7d9266654753cc297e7d2edfe0bac1cdcf9f717241550e0a7b191195b7667bb4f64bcb8e2121380fd1d9d46ad2d92d2d15605093924cceaf74c4861eff62abf69b9291ed0a340e113be11e6a7d3113e92484cf7045cc7")]

sdk/eventhub/Azure.Messaging.EventHubs.Shared/src/Processor/PartitionLoadBalancer.cs

@@ -167,9 +167,11 @@ public virtual async ValueTask<PartitionOwnership> RunLoadBalancingAsync(string[
                 cancellationToken.ThrowIfCancellationRequested<TaskCanceledException>();
 
                 // If ownership list retrieval fails, give up on the current cycle.  There's nothing more we can do
-                // without an updated ownership list.
+                // without an updated ownership list.  Set the EventHubName to null so it doesn't modify the exception
+                // message.  This exception message is used so the processor can retrieve the raw Operation string, and
+                // adding the EventHubName would append unwanted info to it.
 
-                throw new EventHubsException(true, EventHubName, Resources.OperationListOwnership, ex);
+                throw new EventHubsException(true, null, Resources.OperationListOwnership, ex);
             }
 
             // There's no point in continuing the current cycle if we failed to fetch the completeOwnershipList.
@@ -192,7 +194,7 @@ public virtual async ValueTask<PartitionOwnership> RunLoadBalancingAsync(string[
 
             foreach (PartitionOwnership ownership in completeOwnershipList)
             {
-                if (utcNow.Subtract(ownership.LastModifiedTime.Value) < OwnershipExpiration && !string.IsNullOrWhiteSpace(ownership.OwnerIdentifier))
+                if (utcNow.Subtract(ownership.LastModifiedTime.Value) < OwnershipExpiration && !string.IsNullOrEmpty(ownership.OwnerIdentifier))
                 {
                     if (ActiveOwnershipWithDistribution.ContainsKey(ownership.OwnerIdentifier))
                     {
@@ -416,7 +418,12 @@ private async Task RenewOwnershipAsync(CancellationToken cancellationToken)
                 // end up losing some of its ownership.
 
                 Logger.RenewOwnershipError(OwnerIdentifier, ex.Message);
-                throw new EventHubsException(true, EventHubName, Resources.OperationRenewOwnership, ex);
+
+                // Set the EventHubName to null so it doesn't modify the exception message. This exception message is
+                // used so the processor can retrieve the raw Operation string, and adding the EventHubName would append
+                // unwanted info to it.
+
+                throw new EventHubsException(true, null, Resources.OperationRenewOwnership, ex);
             }
             finally
             {
@@ -472,7 +479,11 @@ private async Task<PartitionOwnership> ClaimOwnershipAsync(string partitionId,
 
                 Logger.ClaimOwnershipError(partitionId, ex.Message);
 
-                throw new EventHubsException(true, EventHubName, Resources.OperationClaimOwnership, ex);
+                // Set the EventHubName to null so it doesn't modify the exception message. This exception message is
+                // used so the processor can retrieve the raw Operation string, and adding the EventHubName would append
+                // unwanted info to it.
+
+                throw new EventHubsException(true, null, Resources.OperationClaimOwnership, ex);
             }
 
             // We are expecting an enumerable with a single element if the claim attempt succeeds.

sdk/eventhub/Azure.Messaging.EventHubs.Shared/src/Testing/EventHubScope.cs

@@ -10,7 +10,6 @@
 using Microsoft.Azure.Management.EventHub.Models;
 using Microsoft.Azure.Management.ResourceManager;
 using Microsoft.Rest;
-using Microsoft.Rest.Azure;
 
 namespace Azure.Messaging.EventHubs.Tests
 {

sdk/eventhub/Azure.Messaging.EventHubs.Shared/src/Testing/MockCheckPointStorage.cs

@@ -20,7 +20,7 @@ namespace Azure.Messaging.EventHubs.Tests
     ///   store the checkpoints and partition ownership to a persistent store instead.
     /// </summary>
     ///
-    internal sealed class MockCheckPointStorage : StorageManager
+    internal class MockCheckPointStorage : StorageManager
     {
         /// <summary>The primitive for synchronizing access during ownership update.</summary>
         private readonly object _ownershipLock = new object();

sdk/eventhub/Azure.Messaging.EventHubs/src/EventData.cs

@@ -182,7 +182,6 @@ public Stream BodyAsStream
         /// <param name="eventBody">The raw data to use as the body of the event.</param>
         ///
         public EventData(ReadOnlyMemory<byte> eventBody) : this(eventBody, lastPartitionSequenceNumber: null)
-
         {
         }