CreateIfNotExists/DeleteIfExists logs exception#9551
Merged
amnguye merged 3 commits intoAzure:masterfrom Feb 14, 2020
Merged
Conversation
amnguye
requested review from
JoshLove-msft,
seanmcc-msft and
tg-msft
as code owners
seanmcc-msft
approved these changes
Jan 21, 2020
Member
|
Do you have unit tests for when the blob exists, doesn't exist, and another exception is thrown? |
Member
Author
Just pushed up some more changes to add the tests missing the error/exception tests. The ones that were missing were for BlobBaseClient for DeleteIfExists and ContainerClient for CreateIfNotExists/DeleteIfNotExists. The other tests exists already. |
seanmcc-msft
approved these changes
Jan 23, 2020
amnguye
force-pushed
the
storage/blobs/update/existsthrowlogexception
branch
2 times, most recently
from
cc70afa to
95cd0a8
Compare
amnguye
force-pushed
the
storage/blobs/update/existsthrowlogexception
branch
from
95cd0a8 to
b3b99f2
Compare
…entTests CreateIfNotExists/DeleteIfExists
amnguye
force-pushed
the
storage/blobs/update/existsthrowlogexception
branch
from
b3b99f2 to
65c8b0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #9275