Skip to content

[Event Hubs Client] Track Two (Formatting Pass) #9039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsquire merged 1 commit into from
Dec 9, 2019
Merged

[Event Hubs Client] Track Two (Formatting Pass) #9039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...Messaging.EventHubs.Processor/tests/BlobsCheckpointStore/BlobsCheckpointStoreLiveTests.cs
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
using Azure.Messaging.EventHubs.Core;
using Azure.Messaging.EventHubs.Tests;
using Azure.Storage.Blobs;
using Moq;
using NUnit.Framework;

namespace Azure.Messaging.EventHubs.Processor.Tests
Expand Down
1 change: 0 additions & 1 deletion ...ure.Messaging.EventHubs.Processor/tests/BlobsCheckpointStore/BlobsCheckpointStoreTests.cs
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.

using System;
using Azure.Storage.Blobs;
using Moq;
using NUnit.Framework;
Expand Down
10 changes: 5 additions & 5 deletions ...Messaging.EventHubs.Processor/tests/EventProcessorClient/EventProcessorClientLiveTests.cs
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -999,11 +999,11 @@ public async Task LoadBalancingIsEnforcedWhenDistributionIsUneven()
(
EventHubConsumerClient.DefaultConsumerGroupName,
connectionString
// TODO: fix test. OwnerIdentifier is not accessible anymore.
// onInitialize: eventArgs =>
// ownedPartitionsCount.AddOrUpdate(eventArgs.Context.OwnerIdentifier, 1, (ownerId, value) => value + 1),
// onStop: eventArgs =>
// ownedPartitionsCount.AddOrUpdate(eventArgs.Context.OwnerIdentifier, 0, (ownerId, value) => value - 1)
// TODO: fix test. OwnerIdentifier is not accessible anymore.
// onInitialize: eventArgs =>
// ownedPartitionsCount.AddOrUpdate(eventArgs.Context.OwnerIdentifier, 1, (ownerId, value) => value + 1),
// onStop: eventArgs =>
// ownedPartitionsCount.AddOrUpdate(eventArgs.Context.OwnerIdentifier, 0, (ownerId, value) => value - 1)
);

eventProcessorManager.AddEventProcessors(1);
Expand Down
6 changes: 4 additions & 2 deletions ...ure.Messaging.EventHubs.Processor/tests/EventProcessorClient/EventProcessorClientTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -764,7 +764,8 @@ private static async IAsyncEnumerable<PartitionEvent> MockPartitionEventEnumerab
{
for (var index = 0; index < eventCount; ++index)
{
if (cancellationToken.IsCancellationRequested) { break; }
if (cancellationToken.IsCancellationRequested)
{ break; }
await Task.Delay(25).ConfigureAwait(false);
yield return new PartitionEvent(new MockPartitionContext("fake"), new EventData(Encoding.UTF8.GetBytes($"Event { index }")));
}
Expand All @@ -781,7 +782,8 @@ private static async IAsyncEnumerable<PartitionEvent> MockEmptyPartitionEventEnu
{
for (var index = 0; index < eventCount; ++index)
{
if (cancellationToken.IsCancellationRequested) { break; }
if (cancellationToken.IsCancellationRequested)
{ break; }
await Task.Delay(25).ConfigureAwait(false);
yield return new PartitionEvent();
}
Expand Down
1 change: 0 additions & 1 deletion sdk/eventhub/Azure.Messaging.EventHubs.Shared/src/Authorization/SharedAccessSignature.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
// Licensed under the MIT License.

using System;
using System.ComponentModel;
using System.Globalization;
using System.Net;
using System.Security.Cryptography;
Expand Down
Loading