Fixing UsernamePasswordCredential constructor parameter missordering#8997
Merged
schaabs merged 9 commits intoAzure:masterfrom Dec 6, 2019
Merged
Fixing UsernamePasswordCredential constructor parameter missordering#8997schaabs merged 9 commits intoAzure:masterfrom
schaabs merged 9 commits intoAzure:masterfrom
Conversation
tg-msft
approved these changes
Dec 4, 2019
Member
tg-msft
left a comment
tg-msft
left a comment
There was a problem hiding this comment.
It's definitely scary, but it looks good.
schaabs
requested review from
JoshLove-msft,
amnguye,
annelo-msft and
seanmcc-msft
as code owners
pakrym
approved these changes
Dec 6, 2019
|
|
||
| public int StatusCode { get; set; } | ||
|
|
||
|
|
| public class RecordEntry | ||
| { | ||
| public string RequestUri { get; set; } | ||
| public class Message |
| ResponseBody = ReadToEnd(response), | ||
| Request = | ||
| { | ||
| Headers = new SortedDictionary<string, string[]>(StringComparer.OrdinalIgnoreCase), |
Contributor
There was a problem hiding this comment.
You don't need this initialization.
isra-fel
pushed a commit
that referenced
this pull request
Dec 13, 2019
* Generate 2019-09-01 policy operations (#8927) * Generate 2019-09-01 policy operations * Update generate and build artifacts * Fixed generation metadata * TextAnalytics API Refactoring (#8905) * move errors to document result * api updates per feedback * Remove interface * Include Statistics * updates per API feedback * shift to result collections * TextAnalysisOptions * reenable recognize entity single * reenable recognize entity batch * reenable key phrases * reenable remaining * API feedback * bug fix * pr feedback * pr feedback * Make the AzureServiceTokenProvider mockable (#8464) * Update Smoke Tests for October GA release (#8639) * update package versions to match published GA packages * update to incorporate ga interface changes * update KV interface * remove pinned versions for packages that aren't targeted in smoke tests * Bump to ApiApprover 10.0.1 (#8982) Brings up to speed with PublicApiGenerator 10.0.1 which supports nullable reference types and has more stable member sorting * Fixing UsernamePasswordCredential constructor parameter missordering (#8997) * Fixing UsernamePasswordCredential constructor parameter misordering * adding missed file * exclude header x-client-OS from header matching * excluding x-client-OS and x-client-SKU from header matching * Refactoring RecordedTestSanitizer to enable higher level sanitiation * updates to sanitize test recordings * removing hard coded RecordedTestMode * Fix to RecordEntry serialization * addressing PR feedback' * [Event Hubs Client] Track Two (Samples and Documentation) (#9011) The focus of these changes is to revise the samples for the Event Processor client, extend the set of samples with additional scenarios and flesh out the README content for the samples in each package. Also included are some small refinements to the Event Processor client that were deferred from feedback for an earlier pull request, a fix for an empty partition context when the maximum wait time elapses, and ignoring a test that requires follow-up analysis. * Update package index links in README.md (#9015) Package index is now controlled centrally in the azure-sdk repo https://github.com/Azure/azure-sdk/blob/master/_data/releases/latest/dotnet-packages.csv * Text Analytics AAD Support (#9007) * first try at aad * un-update sample * fix * fix * Update release notes (#9013) * Update release notes * Update CHANGELOG.md Add link to the fixed bug * Checkin Doc Index to Master (#8791) * ensure UserDelegationKey test doesn't use UTC (#9024) * remove reflection (#9021) * Update GoogleAdWords and GoogleBigQuery clientId for fix issue (#9019) * [DataFactory]Add SAP HANA partition settings (#9032) * Releasing latest version of Microsoft.DataBoxEdge SDK (#9008) * Releasing latest version of Microsoft.DataBoxEdge SDK * Generated code through generate.cmd * Update Microsoft.Azure.Management.DataBoxEdge.csproj * Generate sdk using generate.ps1 command and address review comments * Update Microsoft.Azure.Management.DataBoxEdge.csproj * Regenerate CDN for API version 2019-06-15-preview.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8965