[Compute] Adding 'Spot' value to 'Priority' Enum.#8811
Merged
isra-fel merged 4 commits intoAzure:masterfrom Dec 2, 2019
Merged
[Compute] Adding 'Spot' value to 'Priority' Enum.#8811isra-fel merged 4 commits intoAzure:masterfrom
isra-fel merged 4 commits intoAzure:masterfrom
Conversation
Contributor
rakeshakkera
commented
Nov 15, 2019
rakeshakkera
commented
- SDK Tests related to swagger update: Moving Priority and EvictionPolicy enum to the definitions section and adding 'Spot' priority. Updating both 2019-03-01 and 2019-07-01 Api versions. azure-rest-api-specs#7748.
- Refactored the test class "VMScaleSetPriorityTests"
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 25 pipeline(s). |
hyonholee
reviewed
Nov 19, 2019
sdk/compute/Microsoft.Azure.Management.Compute/tests/VMScaleSetTests/VMScaleSetPriorityTests.cs
Outdated
Show resolved
Hide resolved
hyonholee
reviewed
Nov 19, 2019
sdk/compute/Microsoft.Azure.Management.Compute/tests/VMScaleSetTests/VMScaleSetPriorityTests.cs
Outdated
Show resolved
Hide resolved
hyonholee
reviewed
Nov 19, 2019
sdk/compute/Microsoft.Azure.Management.Compute/tests/VMScaleSetTests/VMScaleSetPriorityTests.cs
Outdated
Show resolved
Hide resolved
hyonholee
reviewed
Nov 19, 2019
sdk/compute/Microsoft.Azure.Management.Compute/tests/VMScaleSetTests/VMScaleSetPriorityTests.cs
Outdated
Show resolved
Hide resolved
isra-fel
requested changes
Nov 20, 2019
Member
isra-fel
left a comment
isra-fel
left a comment
There was a problem hiding this comment.
Hi @rakeshakkera could you
- Include the
.txtfile generated when you rungenerate.ps1(details) - Update versions in csproj,
AssemblyInfo.cs
Thanks
isra-fel
added
Mgmt
Contributor
|
Now, this PR also includes #8915 |
hyonholee
changed the title
Contributor
|
@isra-fel Hi, @rakeshakkera updated the version number and included the .txt file. (Also, regenerated from the latest Swagger master branch) |
isra-fel
approved these changes
Dec 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.