[Event Hubs Client] Track Two (Credential Fix) #8786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquire
added
Event Hubs
Client
jsquire
requested review from
AlexGhiondea,
ShivangiReja,
kinelski and
serkantkaraca
jsquire
force-pushed
the
eventhubs/credential-fix
branch
from
92e41c4 to
8fcb605
Compare
kinelski
approved these changes
Nov 14, 2019
sdk/eventhub/Azure.Messaging.EventHubs/src/Authorization/SharedAccessSignature.cs
Outdated
Show resolved
Hide resolved
sdk/eventhub/Azure.Messaging.EventHubs/src/Authorization/SharedAccessSignature.cs
Outdated
Show resolved
Hide resolved
sdk/eventhub/Azure.Messaging.EventHubs/tests/Authorization/SharedAccessSignatureTests.cs
Outdated
Show resolved
Hide resolved
...enthub/Azure.Messaging.EventHubs/tests/Authorization/SharedAccessSignatureCredentialTests.cs
Outdated
Show resolved
Hide resolved
sdk/eventhub/Azure.Messaging.EventHubs/tests/Authorization/EventHubSharedKeyCredentialTests.cs
Outdated
Show resolved
Hide resolved
sdk/eventhub/Azure.Messaging.EventHubs/tests/Authorization/EventHubSharedKeyCredentialTests.cs
Outdated
Show resolved
Hide resolved
The focus of these changes is to provide better synchronization for the shared access signature credential used for connection string-provided credentials to ensure that the signature and expiration date are in-sync when the expiration is extended.
jsquire
force-pushed
the
eventhubs/credential-fix
branch
from
8fcb605 to
f074330
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The focus of these changes is to provide better synchronization for the shared access signature credential used for connection string-provided credentials to ensure that the signature and expiration date are in-sync when the expiration is extended.
Last Upstream Rebase
Thursday, November 14, 3:01pm (EST)
Related and Follow-Up Issues