[Azure Search] Regenerate SDK for access condition methods #8762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
(I hit create pull request instead of create draft pull request by mistake. |
brjohnstmsft
suggested changes
Nov 14, 2019
Member
brjohnstmsft
left a comment
brjohnstmsft
left a comment
There was a problem hiding this comment.
Missing test coverage, and maybe custom code too? Please ensure the ETag-related surface area for skillsets is at par with the other resources.
...osoft.Azure.Search.Service/src/Customizations/DataSources/Models/DataSource.Customization.cs
Show resolved
Hide resolved
Member
Author
Yup, just added some more tests and ensured that the surface area is consistent (compared with DataSource for example) |
brjohnstmsft
approved these changes
Nov 14, 2019
Member
brjohnstmsft
left a comment
brjohnstmsft
left a comment
There was a problem hiding this comment.
Minor doc bug, otherwise looks good.
...soft.Azure.Search.Service/src/Customizations/Skillsets/ISkillsetsOperations.Customization.cs
Outdated
Show resolved
Hide resolved
brjohnstmsft
approved these changes
Nov 14, 2019
bleroy
approved these changes
Nov 19, 2019
...osoft.Azure.Search.Service/src/Customizations/DataSources/Models/DataSource.Customization.cs
Outdated
Show resolved
Hide resolved
...soft.Azure.Search.Service/src/Customizations/Skillsets/ISkillsetsOperations.Customization.cs
Outdated
Show resolved
Hide resolved
...soft.Azure.Search.Service/src/Customizations/Skillsets/ISkillsetsOperations.Customization.cs
Outdated
Show resolved
Hide resolved
...soft.Azure.Search.Service/src/Customizations/Skillsets/ISkillsetsOperations.Customization.cs
Outdated
Show resolved
Hide resolved
...osoft.Azure.Search.Service/src/Customizations/Skillsets/SkillsetsOperations.Customization.cs
Show resolved
Hide resolved
...osoft.Azure.Search.Service/src/Customizations/Skillsets/SkillsetsOperations.Customization.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regenerate from [Azure Search] Add access condition to skillset operations azure-rest-api-specs#7777 to pull in access condition methods for skillsets.
Add
MySQLdata source type which is in preview.