[Microsoft.StorageSync] Update SDK to use 2019-06-01 API version#8632
Merged
isra-fel merged 3 commits intoAzure:masterfrom Nov 7, 2019
anpint:anpint-storagesync-20199601
Merged
[Microsoft.StorageSync] Update SDK to use 2019-06-01 API version#8632isra-fel merged 3 commits intoAzure:masterfrom anpint:anpint-storagesync-20199601
isra-fel merged 3 commits intoAzure:masterfrom
anpint:anpint-storagesync-20199601
Conversation
isra-fel
requested changes
Nov 6, 2019
Member
isra-fel
left a comment
isra-fel
left a comment
There was a problem hiding this comment.
Hi @anpint
- Please add a link to the swagger spec review PR(s) in the description
- There are breaking changes, such as renaming a model class, so please update the major version number
- Please also update
AssemblyVersionandAssemblyFileVersioninAssemblyInfo.cs.
Thanks
isra-fel
added
Mgmt
Member
Author
@isra-fel thanks for reviewing the changes. I've made the changes you request. |
isra-fel
approved these changes
Nov 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check list:
Update recorded tests
Identity of QA responsible for feature testing (can be conducted post-merging of the pull request):
Our QA consists of running recorded unit tests, and recorded tests for the Az.StorageSync module that cosumes the SDK (will be updated after SDK is merged and nuget is released).
Short description of the payload of pull request.
This PR updates the StorageSync .NET SDK to consume our new API version - 2019-06-01. This API version introduces some new properties on the server endpoint object to relay cloud tiering and recall status of the server endpoint.
StorageSync 2019-06-01 API version: Azure/azure-rest-api-specs#7337