Skip to content

Conversation

@chidozieononiwu
Copy link
Member

No description provided.

Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Key Vault

Copy link
Member

@annelo-msft annelo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for AppConfig.

@chidozieononiwu chidozieononiwu merged commit a0ab5c9 into Azure:master Nov 2, 2019
@chidozieononiwu chidozieononiwu deleted the BumpUpVersionsAfterGA branch November 2, 2019 00:06
<Description>Azure Client SDK integration with Microsoft.Extensions libraries</Description>
<AssemblyTitle>Azure Client SDK integration Microsoft.Extensions</AssemblyTitle>
<VersionPrefix>1.0.0</VersionPrefix>
<VersionPrefix>1.1.0-preview.1</VersionPrefix>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need to do a pass over the repo and change any of these VersionPrefix properties to Version

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants