Skip to content

Create/destroy keyvault for live tests#8492

Closed
heaths wants to merge 8 commits intomasterfrom
live-tests
Closed

Create/destroy keyvault for live tests#8492
heaths wants to merge 8 commits intomasterfrom
live-tests

Conversation

@heaths
Copy link
Copy Markdown
Member

@heaths heaths commented Oct 28, 2019

No description provided.

weshaggard
weshaggard reviewed Oct 29, 2019
View reviewed changes
weshaggard
weshaggard reviewed Oct 29, 2019
View reviewed changes
weshaggard
weshaggard reviewed Oct 29, 2019
View reviewed changes
weshaggard
weshaggard reviewed Oct 29, 2019
View reviewed changes
pakrym
pakrym reviewed Oct 29, 2019
View reviewed changes
@danieljurek
Copy link
Copy Markdown
Member

danieljurek commented Oct 29, 2019

/azp run net - keyvault - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Oct 29, 2019

Azure Pipelines failed to run 1 pipeline(s).

@heaths
Copy link
Copy Markdown
Member Author

heaths commented Oct 30, 2019

/azp run net - keyvault - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Oct 30, 2019

Azure Pipelines failed to run 1 pipeline(s).

@heaths
Copy link
Copy Markdown
Member Author

heaths commented Oct 30, 2019

/azp run net - keyvault - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Oct 30, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@heaths
Copy link
Copy Markdown
Member Author

heaths commented Oct 30, 2019

/azp run net - keyvault - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Oct 30, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@heaths
Copy link
Copy Markdown
Member Author

heaths commented Oct 30, 2019

/azp run net - keyvault - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Oct 30, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@heaths
Copy link
Copy Markdown
Member Author

heaths commented Oct 30, 2019

/azp run net - keyvault - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Oct 30, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@heaths
Wait for resource group creation
cb6f3ac 
Was always failing on Windows
@heaths
Copy link
Copy Markdown
Member Author

heaths commented Oct 30, 2019

/azp run net - keyvault - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Oct 30, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@heaths
Copy link
Copy Markdown
Member Author

heaths commented Oct 30, 2019

/azp run net - keyvault - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Oct 30, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@heaths heaths marked this pull request as ready for review October 30, 2019 20:58
@heaths
Copy link
Copy Markdown
Member Author

heaths commented Oct 30, 2019

I'm setting up a meeting for next week to discuss this long-term. For now, I'd like to get this in so nightlies are passing.

@heaths heaths requested a review from weshaggard October 30, 2019 22:16
weshaggard
weshaggard reviewed Oct 31, 2019
View reviewed changes
sdk/keyvault/tests.yml
AZURE_TENANT_ID: $(aad-azure-sdk-test-tenant-id)
AZURE_CLIENT_ID: $(net-keyvault-azure-client-id)
AZURE_CLIENT_SECRET: $(net-keyvault-azure-client-secret)
AZURE_KEYVAULT_URL: $(net-keyvault-azure-keyvault-url)
Copy link
Copy Markdown
Member

@weshaggard weshaggard Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you still need to switch this to $[..] to make it be runtime evaluated? https://docs.microsoft.com/en-us/azure/devops/pipelines/process/expressions?view=azure-devops

Copy link
Copy Markdown
Member Author

@heaths heaths Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose it wouldn't hurt, but should be unnecessary since the code below actually overwrites that variable and the environment variable. And it seemed to work.

@heaths
Copy link
Copy Markdown
Member Author

heaths commented Jan 6, 2020

Closing in favor of #9029 and #9127.

@heaths heaths closed this Jan 6, 2020
@heaths heaths deleted the live-tests branch January 6, 2020 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weshaggard weshaggard weshaggard left review comments

@danieljurek danieljurek Awaiting requested review from danieljurek

@schaabs schaabs Awaiting requested review from schaabs

@chidozieononiwu chidozieononiwu Awaiting requested review from chidozieononiwu

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

+1 more reviewer

@pakrym pakrym pakrym left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@heaths @danieljurek @pakrym @weshaggard