Additional DataLake refactoring #8486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshLove-msft
approved these changes
Oct 28, 2019
| } | ||
|
|
||
| public IDisposable GetNewFile(out FileClient file, DataLakeServiceClient service = default, string fileSystemName = default, string directoryName = default, string fileName = default) | ||
| public IDisposable GetNewFile(out DataLakeFileClient file, DataLakeServiceClient service = default, string fileSystemName = default, string directoryName = default, string fileName = default) |
Member
There was a problem hiding this comment.
We recently updated our tests for the other libraries to change how the GetNewX is implemented so that it doesn't use sync over async. You can look at DisposingContainer and how it is used as an example. Not sure if you want to address that as part of this PR, but thought I would mention it.
Member
Author
There was a problem hiding this comment.
When was this changed? It would be great if changes like this are made across all packages at the same time in the future.
Member
There was a problem hiding this comment.
I believe it was made before Datalake had merged in.
amnguye
approved these changes
Oct 29, 2019
This was referenced Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.