[Azure Search] Branding changes to Azure Cognitive Search#8316
Merged
arv100kri merged 2 commits intoOct 22, 2019
Conversation
Member
|
The management plane changes look good to me. Just a reminder: you'll need another PR to bump up versions (if you'd like to publish a new version) |
Member
|
@bleroy We shouldn’t make the management plane changes!! The responsibility there is with Mike’s team. we only own and ship the data plane |
…arch customizations
…osoft.Azure.Search.Data from changes in spec files
bleroy
force-pushed
the
beleroy/branding-azure-cognitive-search
branch
from
e45a45f to
e0a81ce
Compare
arv100kri
changed the title
Member
We have reverted the changes to the management plane side. And yes, we’ll have a separate PR to bump the version and changelog for a release |
arv100kri
approved these changes
Oct 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR integrates changes already done to the specs under the generated changeset, as well as new changes to the non-generated classes. These changes are only in doc comments, never in code.