Skip to content

Make Response[<T>] easier to use in debugger#8300

Merged
pakrym merged 3 commits into
Azure:masterfrom
pakrym:pakrym/response-debug
Oct 21, 2019
Merged

Make Response[<T>] easier to use in debugger#8300
pakrym merged 3 commits into
Azure:masterfrom
pakrym:pakrym/response-debug

Conversation

@pakrym
Copy link
Copy Markdown
Contributor

@pakrym pakrym commented Oct 21, 2019

Adds ToString and debugger proxy to show GetRawResponse value:
image

Copy link
Copy Markdown
Member

@tg-msft tg-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wish we could put Value over GetRawResponse, but this is a great change.

Comment thread sdk/core/Azure.Core/src/Shared/NoBodyResponse{T}.cs
_response = response;
}

public Response GetRawResponse => _response.GetRawResponse();
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Comment thread sdk/storage/Azure.Storage.Blobs.Batching/src/DelayedResponse.cs Outdated
@pakrym
Copy link
Copy Markdown
Contributor Author

pakrym commented Oct 21, 2019

Approved.

@pakrym pakrym merged commit 43a178c into Azure:master Oct 21, 2019
@pakrym pakrym deleted the pakrym/response-debug branch October 21, 2019 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants