Storage: Use WithSnapshot for Files#8281
Merged
Merged
Conversation
Member
|
Have you re-rerun the related live tests? |
seanmcc-msft
requested changes
Oct 21, 2019
Member
seanmcc-msft
left a comment
seanmcc-msft
left a comment
There was a problem hiding this comment.
Do we not have any unit tests for file or directory snapshots?
Member
Author
|
No - there isn't meaningful test coverage. We create a snapshot and verify that calling WithSnapshot updates the Uri. |
seanmcc-msft
approved these changes
Oct 21, 2019
Member
Author
|
/azp run net - storage - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
amnguye
approved these changes
Oct 21, 2019
Member
Author
|
Yes, I've run live tests for Files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8076