Skip to content

Retry transport exceptions #8247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pakrym merged 1 commit into from
Oct 19, 2019
Merged

Retry transport exceptions #8247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sdk/core/Azure.Core/src/ResponseClassifier.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ public virtual bool IsRetriableResponse(HttpMessage message)
/// </summary>
public virtual bool IsRetriableException(Exception exception)
{
return (exception is IOException);
return (exception is IOException) ||
(exception is RequestFailedException requestFailed && requestFailed.Status == 0);
}

/// <summary>
Expand Down
32 changes: 32 additions & 0 deletions sdk/core/Azure.Core/tests/HttpPipelineFunctionalTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,38 @@ public async Task NonBufferedExtractedStreamReadableAfterMessageDisposed()
}
}

[Test]
public async Task RetriesTransportFailures()
{
int i = 0;
HttpPipeline httpPipeline = HttpPipelineBuilder.Build(new TestOptions());

using TestServer testServer = new TestServer(
context =>
{
if (i == 0)
{
context.Abort();
}
else
{
context.Response.StatusCode = 201;
}

i++;
return Task.CompletedTask;
});

using HttpMessage message = httpPipeline.CreateMessage();
message.Request.Uri.Reset(testServer.Address);
message.BufferResponse = false;

await httpPipeline.SendAsync(message, CancellationToken.None);

Assert.AreEqual(message.Response.Status, 201);
Assert.AreEqual(i, 2);
}

private class TestOptions : ClientOptions
{
}
Expand Down