[Storage] Replace DeleteSnapshotOption with bool includeSnapshots on Delete#7941
Closed
ShivangiReja wants to merge 2 commits into
Closed
[Storage] Replace DeleteSnapshotOption with bool includeSnapshots on Delete#7941ShivangiReja wants to merge 2 commits into
DeleteSnapshotOption with bool includeSnapshots on Delete#7941ShivangiReja wants to merge 2 commits into
Conversation
ShivangiReja
requested review from
amnguye,
seanmcc-msft and
tg-msft
as code owners
ShivangiReja
added
Client
tg-msft
approved these changes
Oct 5, 2019
amnguye
approved these changes
Oct 9, 2019
tg-msft
requested changes
Oct 10, 2019
Member
tg-msft
left a comment
tg-msft
left a comment
There was a problem hiding this comment.
I want to take another look at this before it's merged. I'm worried I was wrong about the semantics.
seanmcc-msft
approved these changes
Oct 19, 2019
Member
|
Looks like I was wrong when I said we could use a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per API review remove
DeleteSnapshotsOptionand replace it withbool includeSnapshots = truein theBlobClient.Deletemethod.