Skip to content

billing plan sdk update#7872

Merged
isra-fel merged 7 commits intoAzure:masterfrom
Only2125:xishan/azure-sdk
Oct 8, 2019
Merged

billing plan sdk update#7872
isra-fel merged 7 commits intoAzure:masterfrom
Only2125:xishan/azure-sdk

Conversation

@Only2125
Copy link
Contributor

@Only2125 Only2125 commented Oct 1, 2019

Azure/azure-rest-api-specs#7206

Reservations RP Billing Plan SDK change.

@Only2125 Only2125 requested a review from erich-wang as a code owner October 1, 2019 23:53
@AlexGhiondea
Copy link
Contributor

@Only2125 could you add a PR description?

Copy link
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the following to thsi PR:
(1) In the description, a link to your PR in rest-api-specs
(2) The metadata file generated by generate.ps1 ahould be updated here: eng\mgmt\mgmtmetadata\<rpName>.txt

@markcowl markcowl added Mgmt This issue is related to a management package. needs-revision labels Oct 2, 2019
@Only2125
Copy link
Contributor Author

Only2125 commented Oct 3, 2019

Please add the following to thsi PR:
(1) In the description, a link to your PR in rest-api-specs
(2) The metadata file generated by generate.ps1 ahould be updated here: eng\mgmt\mgmtmetadata<rpName>.txt

updated the metadata file and linked the swagger PR in the discription

@Only2125
Copy link
Contributor Author

Only2125 commented Oct 3, 2019

@Only2125 could you add a PR description?

Hi, This PR is for Reservation RP releasing the .NET SDK for our new feature: Billing Plan. I have linked the swagger change of Billing Plan

@isra-fel
Copy link
Member

isra-fel commented Oct 8, 2019

Hey @Only2125
If you take a look at the changes in eng/mgmt/mgmtmetadata/reservations_resource-manager.txt you'll know its format is completely changed.
I suppose you were using the old generate.cmd to generate the SDK, but you really need to use generate.ps1.
So please regenerate your SDK code with generate.ps1. We expect the txt to have 3 lines changed. For example: https://github.com/Azure/azure-sdk-for-net/pull/7795/files#diff-50aabe71ddf9112b9d32088c493b59b8

Thanks

@Only2125
Copy link
Contributor Author

Only2125 commented Oct 8, 2019

Hey @Only2125
If you take a look at the changes in eng/mgmt/mgmtmetadata/reservations_resource-manager.txt you'll know its format is completely changed.
I suppose you were using the old generate.cmd to generate the SDK, but you really need to use generate.ps1.
So please regenerate your SDK code with generate.ps1. We expect the txt to have 3 lines changed. For example: https://github.com/Azure/azure-sdk-for-net/pull/7795/files#diff-50aabe71ddf9112b9d32088c493b59b8
Thanks

Hi @isra-fel

Hey @Only2125
If you take a look at the changes in eng/mgmt/mgmtmetadata/reservations_resource-manager.txt you'll know its format is completely changed.
I suppose you were using the old generate.cmd to generate the SDK, but you really need to use generate.ps1.
So please regenerate your SDK code with generate.ps1. We expect the txt to have 3 lines changed. For example: https://github.com/Azure/azure-sdk-for-net/pull/7795/files#diff-50aabe71ddf9112b9d32088c493b59b8
Thanks

Hi there,
I just published a new iteration, generate the file by using generate.ps1. Please take a look. Let me know
Thanks

@Only2125 Only2125 closed this Oct 8, 2019
@isra-fel
Copy link
Member

isra-fel commented Oct 8, 2019

@Only2125 did you just close the PR by accident?

@Only2125
Copy link
Contributor Author

Only2125 commented Oct 8, 2019 via email

@isra-fel isra-fel reopened this Oct 8, 2019
@isra-fel
Copy link
Member

isra-fel commented Oct 8, 2019

/azp run net - mgmt - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@isra-fel isra-fel dismissed markcowl’s stale review October 8, 2019 07:27

requests meet

@isra-fel isra-fel merged commit 4775c09 into Azure:master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants