Skip to content

Conversation

@misosic-msft
Copy link
Contributor

Adding RestoreDetails API and modifying CompleteRestore.

@jaredmoo
Copy link
Contributor

jaredmoo commented Oct 3, 2019

Adding E2E test?

@markcowl
Copy link
Member

markcowl commented Oct 4, 2019

@misosic-msft Please respond to @jaredmoo comment

@misosic-msft
Copy link
Contributor Author

Adding E2E test?

I will add E2E test in the next commit.

@markcowl
Copy link
Member

markcowl commented Oct 7, 2019

  • looks good from my perspective, other than the testing comment from Jared. ny reason we need to merge this now instead of waiting for the tests in the next commit?

@misosic-msft
Copy link
Contributor Author

  • looks good from my perspective, other than the testing comment from Jared. ny reason we need to merge this now instead of waiting for the tests in the next commit?

No need to merge before I add tests. Thanks!

@isra-fel isra-fel added the Mgmt This issue is related to a management package. label Oct 8, 2019
@isra-fel
Copy link
Member

@misosic-msft ping on this

@misosic-msft
Copy link
Contributor Author

@misosic-msft ping on this

I've noticed a change needed before new API can be used from clients. ARM manifest needs to be updated. Either we can leave this PR open and waiting for other changes or we can close it.

@misosic-msft
Copy link
Contributor Author

I've added the test for new API. All working as expected. This can be merged now.

@Azure Azure deleted a comment from azure-pipelines bot Oct 21, 2019
@Azure Azure deleted a comment from azure-pipelines bot Oct 21, 2019
@isra-fel isra-fel closed this Oct 21, 2019
@isra-fel isra-fel reopened this Oct 21, 2019
@isra-fel
Copy link
Member

/azp run net - mgmt - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@isra-fel
Copy link
Member

isra-fel commented Oct 21, 2019

Sorry I accidently triggered the running of more CI tasks than it needs... but you only need to make sure net - mgmt - ci and its sub-jobs are passing. Thanks @misosic-msft

@misosic-msft
Copy link
Contributor Author

I've fixed the failing checks now. Thanks @isra-fel

Copy link
Contributor

@jaredmoo jaredmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update version number in AssemblyInfo.cs and .csproj. Also update release notes in .csproj. Compare against the most recent release at https://www.nuget.org/packages/Microsoft.Azure.Management.Sql .

@isra-fel
Copy link
Member

jaredmoo is right. And given you were changing the API versions you use, please also update the tags in AzSDK.RP.props

@misosic-msft
Copy link
Contributor Author

jaredmoo is right. And given you were changing the API versions you use, please also update the tags in AzSDK.RP.props

It's auto generated and contains 2018 version.

@misosic-msft misosic-msft requested a review from isra-fel October 22, 2019 08:45
@isra-fel isra-fel merged commit d3a4cff into Azure:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants