-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Refreshing SQL ManagedDatabase SDK. #7808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...oft.Azure.Management.SqlManagement/src/Generated/IManagedDatabaseRestoreDetailsOperations.cs
Show resolved
Hide resolved
|
Adding E2E test? |
|
@misosic-msft Please respond to @jaredmoo comment |
I will add E2E test in the next commit. |
|
No need to merge before I add tests. Thanks! |
|
@misosic-msft ping on this |
I've noticed a change needed before new API can be used from clients. ARM manifest needs to be updated. Either we can leave this PR open and waiting for other changes or we can close it. |
|
I've added the test for new API. All working as expected. This can be merged now. |
|
/azp run net - mgmt - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Sorry I accidently triggered the running of more CI tasks than it needs... but you only need to make sure net - mgmt - ci and its sub-jobs are passing. Thanks @misosic-msft |
|
I've fixed the failing checks now. Thanks @isra-fel |
jaredmoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update version number in AssemblyInfo.cs and .csproj. Also update release notes in .csproj. Compare against the most recent release at https://www.nuget.org/packages/Microsoft.Azure.Management.Sql .
|
jaredmoo is right. And given you were changing the API versions you use, please also update the tags in |
It's auto generated and contains 2018 version. |
Adding RestoreDetails API and modifying CompleteRestore.