Skip to content

[AzureDataFactory]Add Azure File Storage and Google Cloud Storage#7806

Merged
isra-fel merged 3 commits intoAzure:masterfrom
wenbof-zz:master
Sep 30, 2019
Merged

[AzureDataFactory]Add Azure File Storage and Google Cloud Storage#7806
isra-fel merged 3 commits intoAzure:masterfrom
wenbof-zz:master

Conversation

@wenbof-zz
Copy link

@wenbof-zz wenbof-zz commented Sep 29, 2019

No description provided.

@wenbof-zz
Copy link
Author

wenbof-zz commented Sep 29, 2019 •
edited
Loading

Related Swagger change:Azure/azure-rest-api-specs#7308 (comment)

isra-fel
isra-fel requested changes Sep 30, 2019
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wenbof please consider my inline comment, thanks

@isra-fel isra-fel added Mgmt This issue is related to a management package. needs-revision labels Sep 30, 2019
@isra-fel
Copy link
Member

isra-fel commented Sep 30, 2019

Hi @wenbof if you decide to use the version 4.2.0, you need to change AssemblyInfo.cs and changelog.md too

@isra-fel isra-fel assigned isra-fel and unassigned wenbof-zz Sep 30, 2019
wenbof-zz
wenbof-zz commented Sep 30, 2019
View reviewed changes
Copy link
Author

@wenbof-zz wenbof-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Yeming, thanks for your review. I think I would like to still keep the version as 4.2.1 (my previous change is not correct, sorry). so I added back the notes of the 4.2.0 instead. How about now? Please feel free to let me know if there are anything need to be changed.

besides. for the assembly version, as I know that we don't need to change in this case.

@isra-fel
Copy link
Member

isra-fel commented Sep 30, 2019

Hi Yeming, thanks for your review. I think I would like to still keep the version as 4.2.1 (my previous change is not correct, sorry). so I added back the notes of the 4.2.0 instead. How about now? Please feel free to let me know if there are anything need to be changed.

besides. for the assembly version, as I know that we don't need to change in this case.

It looks good to me 😁 Just wait until CI passes.

@isra-fel isra-fel merged commit 562aba3 into Azure:master Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isra-fel isra-fel isra-fel approved these changes

@erich-wang erich-wang Awaiting requested review from erich-wang

Assignees

@isra-fel isra-fel

Labels

Mgmt This issue is related to a management package.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wenbof-zz @isra-fel @wenbof