Skip to content

Comments

updated Azure SDK for swagger updates regarding the new property cal…#7759

Closed
hari-bodicherla wants to merge 2 commits intoAzure:masterfrom
hari-bodicherla:master
Closed

updated Azure SDK for swagger updates regarding the new property cal…#7759
hari-bodicherla wants to merge 2 commits intoAzure:masterfrom
hari-bodicherla:master

Conversation

@hari-bodicherla
Copy link
Contributor

Added Swagger tests for Single VM, VM Scaleset and Image tests to verify the DiskEncryptionSet resource usage.

Added SetSwaggerTestEnvironment.ps1 for setting the test env variables and to invoke the solution file for updating and running the tests in record mode.

Swagger documentation Pull request for reference:
Azure/azure-rest-api-specs#7293
Azure/azure-rest-api-specs#7318

@isra-fel
Copy link
Member

@hari-bodicherla
Azure/azure-rest-api-specs#7318 is still open. I suppose you are going to regenerate SDK after it's merged.
Please let me know if this PR is ready for review.
Thanks

@isra-fel isra-fel added Mgmt This issue is related to a management package. needs-revision labels Sep 26, 2019
@hari-bodicherla
Copy link
Contributor Author

@hari-bodicherla
Azure/azure-rest-api-specs#7318 is still open. I suppose you are going to regenerate SDK after it's merged.
Please let me know if this PR is ready for review.
Thanks

Hi,
This SDK is generated from my forked branch where the azure-rest-api-specs/pull/7318 changes already present. So I think we dont need to regenerate the SDK from the master again once the swagger documentation changes are merged. The only one thing to note is the azure-rest-api-specs/pull/7318 is going to private branch called 2019-07 ( which needs to publish into master for new api version 2019-07-01 yet) . So the current master azure-rest-api-specs branch is not aware of api version 2019-07-01 which are resulting in above failed checks it seems.

@isra-fel
Copy link
Member

Hi,
This SDK is generated from my forked branch where the azure-rest-api-specs/pull/7318 changes already present. So I think we dont need to regenerate the SDK from the master again once the swagger documentation changes are merged. The only one thing to note is the azure-rest-api-specs/pull/7318 is going to private branch called 2019-07 ( which needs to publish into master for new api version 2019-07-01 yet) . So the current master azure-rest-api-specs branch is not aware of api version 2019-07-01 which are resulting in above failed checks it seems.

OK I got it. Please notify me when the spec is merged into master and your PR is ready for review.
Thanks

@hari-bodicherla
Copy link
Contributor Author

Hi,
This SDK is generated from my forked branch where the azure-rest-api-specs/pull/7318 changes already present. So I think we dont need to regenerate the SDK from the master again once the swagger documentation changes are merged. The only one thing to note is the azure-rest-api-specs/pull/7318 is going to private branch called 2019-07 ( which needs to publish into master for new api version 2019-07-01 yet) . So the current master azure-rest-api-specs branch is not aware of api version 2019-07-01 which are resulting in above failed checks it seems.

OK I got it. Please notify me when the spec is merged into master and your PR is ready for review.
Thanks

Sure , I will notify when the spec is merged into master @isra-fel . Thanks

@isra-fel
Copy link
Member

@hari-bodicherla How's going about the spec?

@isra-fel
Copy link
Member

@hari-bodicherla I'll close this PR for now. Feel free to reopen or open a new one to continue. THanks

@isra-fel isra-fel closed this Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants