Skip to content

[DataFactorySDK]-Add AzureFileStorage and GoogleCloudStorage #7752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wenbof-zz wants to merge 1 commit into from
Closed

[DataFactorySDK]-Add AzureFileStorage and GoogleCloudStorage #7752

wenbof-zz wants to merge 1 commit into from

Conversation

@wenbof-zz
Copy link

@wenbof-zz wenbof-zz commented Sep 25, 2019

@wenbof-zz wenbof-zz mentioned this pull request Sep 25, 2019
Merged
5 tasks
@isra-fel isra-fel added Mgmt This issue is related to a management package. needs-revision labels Sep 25, 2019
isra-fel
isra-fel suggested changes Sep 25, 2019
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wenbof , could you pleaes include the .txt file generated when you run generate.ps1? (details)

Thanks

@wenbof-zz
Copy link
Author

wenbof-zz commented Sep 25, 2019 •
edited
Loading

Hi @wenbof , could you pleaes include the .txt file generated when you run generate.ps1? (details)
Thanks

@isra-fel
Thanks for your quick review. This is the rehearsal SDK change for the swagger change. these were generated using local swagger. will generate with the remote master swagger and update another commit to this PR once my swagger change is checked in which will then include the .txt file.

@isra-fel
Copy link
Member

isra-fel commented Sep 25, 2019

@isra-fel
Thanks for your quick review. This is the rehearsal SDK change for the swagger change. these were generated using local swagger. will generate with the remote master swagger and update another commit to this PR once my swagger change is checked in which will then include the .txt file.

Got it. Let me know when it's ready for review. Thanks

@isra-fel
Copy link
Member

isra-fel commented Oct 15, 2019

@wenbof ping on this

@wenbof-zz
Copy link
Author

wenbof-zz commented Oct 15, 2019

Thanks Yeming. Abandon this.

@wenbof-zz wenbof-zz closed this Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erich-wang erich-wang Awaiting requested review from erich-wang

1 more reviewer

@isra-fel isra-fel isra-fel requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wenbof-zz wenbof-zz

Labels

Mgmt This issue is related to a management package.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wenbof-zz @isra-fel @markcowl @wenbof