[Azure Stack] Update fabric admin sdk for 2019-05-01 storage API#7736
Merged
isra-fel merged 3 commits intoAzure:masterfrom Sep 28, 2019
Merged
[Azure Stack] Update fabric admin sdk for 2019-05-01 storage API#7736isra-fel merged 3 commits intoAzure:masterfrom
isra-fel merged 3 commits intoAzure:masterfrom
Conversation
Contributor
Author
|
@bganapa Please help review. |
bganapa
reviewed
Sep 24, 2019
sdk/azurestack/Microsoft.AzureStack.Management.Fabric.Admin/AzSdk.RP.props
Show resolved
Hide resolved
bganapa
reviewed
Sep 24, 2019
...t.AzureStack.Management.Fabric.Admin/src/Microsoft.AzureStack.Management.Fabric.Admin.csproj
Outdated
Show resolved
Hide resolved
bganapa
reviewed
Sep 24, 2019
sdk/azurestack/Microsoft.AzureStack.Management.Fabric.Admin/src/Properties/AssemblyInfo.cs
Outdated
Show resolved
Hide resolved
bganapa
reviewed
Sep 24, 2019
sdk/azurestack/Microsoft.AzureStack.Management.Fabric.Admin/src/Properties/AssemblyInfo.cs
Show resolved
Hide resolved
isra-fel
approved these changes
Sep 25, 2019
Member
|
Looks good to me. @bganapa please let me know if you have any comments. Thanks |
bganapa
approved these changes
Sep 26, 2019
Member
|
@zyxyoshine @bganapa This looks good on SDK team's perspective. If it requires no more review from service team, please notify me so I can get it merged. Thanks. |
Contributor
Author
|
@isra-fel Please help merge it. |
Member
|
@markcowl This is good to be merged, Private validation from the ps-sign is successful |
Member
|
Ah this is already merged :), we are good here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PRs for swagger spec:
Azure/azure-rest-api-specs#6666
Azure/azure-rest-api-specs#6786
Azure/azure-rest-api-specs#6813