Skip to content

[Storage] Support Manage File Share#7550

Merged
isra-fel merged 1 commit intoAzure:masterfrom
blueww:managefile
Sep 11, 2019
Merged

[Storage] Support Manage File Share#7550
isra-fel merged 1 commit intoAzure:masterfrom
blueww:managefile

Conversation

@blueww
Copy link
Member

@blueww blueww commented Sep 10, 2019

Support Manage File Share and File Service Properties.

The SRP SDK code is generated from latest public swagger.

@blueww blueww requested a review from erich-wang as a code owner September 10, 2019 03:48
@blueww
Copy link
Member Author

blueww commented Sep 11, 2019

@erich-wang
Would you please help to look at the PR? We have a PSH feature which target code complete on 9/16 , depends on the PR merge to raise PSH PR.

There are 2 build failure, it seems not caused by my code, would you please help to look?
As I see, the error is:

D:\a\1\AzureSDKEngSystem\Net\SourceDirectory\eng\Directory.Build.Data.targets : error : Failed to resolve SDK 'Microsoft.Build.CentralPackageVersions/2.0.36'. Package restore was successful but a package with the ID of "Microsoft.Build.CentralPackageVersions" was not installed.

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel isra-fel merged commit 3fd9df4 into Azure:master Sep 11, 2019
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-net Oct 21, 2019
updating sdk tags for 2019-10-01 api version (#7550)

* updating sdk tags for 2019-10-01 api version

* fixing ci errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants