Skip to content

SDK and tests for hybrid RP#7482

Merged
isra-fel merged 5 commits intoAzure:masterfrom
farehar:master
Oct 24, 2019
Merged

SDK and tests for hybrid RP#7482
isra-fel merged 5 commits intoAzure:masterfrom
farehar:master

Conversation

@farehar
Copy link
Copy Markdown
Contributor

@farehar farehar commented Sep 5, 2019

@farehar farehar requested a review from erich-wang as a code owner September 5, 2019 17:57
@isra-fel isra-fel self-assigned this Sep 6, 2019
@isra-fel isra-fel added Mgmt This issue is related to a management package. needs-review labels Sep 6, 2019
@isra-fel isra-fel assigned farehar and unassigned isra-fel Sep 6, 2019
@farehar farehar requested a review from isra-fel September 6, 2019 21:37
Copy link
Copy Markdown
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @farehar ,

  • could you put a link to the swagger review PR(s) in description
  • As a public preview SDK, its spec should also be in the public spec repo. Please update generate.ps1 so that it doesn't point to the private spec repo
  • And you'll see a .txt file after running generate.ps1, please also check it in
  • please also check in AssemblyInfo.cs, and make sure the versions in it are updated

Thanks

@isra-fel
Copy link
Copy Markdown
Member

@farehar ping on this

@farehar
Copy link
Copy Markdown
Contributor Author

farehar commented Oct 15, 2019

@isra-fel : One of the feedback was to move our swagger spec to public repository. We weren't ready to do that last month. I've created a pull request in public repository today. If i address rest of the feedback, would we be able to merge before swagger spec PR is complete?

@isra-fel
Copy link
Copy Markdown
Member

@isra-fel : One of the feedback was to move our swagger spec to public repository. We weren't ready to do that last month. I've created a pull request in public repository today. If i address rest of the feedback, would we be able to merge before swagger spec PR is complete?

Nope, sorry. SDK should be generated based on merged spec.

@farehar
Copy link
Copy Markdown
Contributor Author

farehar commented Oct 23, 2019

@isra-fel : I've addressed all the feedback. Here's the link to our swagger spec in public repository https://github.com/Azure/azure-rest-api-specs/tree/master/specification/hybridcompute/resource-manager

Copy link
Copy Markdown
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@farehar Please CIL thanks

@isra-fel isra-fel merged commit 344b67f into Azure:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants