SDK and tests for hybrid RP#7482
Conversation
isra-fel
left a comment
There was a problem hiding this comment.
Hi @farehar ,
- could you put a link to the swagger review PR(s) in description
- As a public preview SDK, its spec should also be in the public spec repo. Please update
generate.ps1so that it doesn't point to the private spec repo - And you'll see a .txt file after running
generate.ps1, please also check it in - please also check in
AssemblyInfo.cs, and make sure the versions in it are updated
Thanks
|
@farehar ping on this |
|
@isra-fel : One of the feedback was to move our swagger spec to public repository. We weren't ready to do that last month. I've created a pull request in public repository today. If i address rest of the feedback, would we be able to merge before swagger spec PR is complete? |
Nope, sorry. SDK should be generated based on merged spec. |
|
@isra-fel : I've addressed all the feedback. Here's the link to our swagger spec in public repository https://github.com/Azure/azure-rest-api-specs/tree/master/specification/hybridcompute/resource-manager |
Azure/azure-rest-api-specs#7568