Task 5207653: RI renewal: Dot net sdk changes. #7386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isra-fel
suggested changes
Aug 26, 2019
Member
isra-fel
left a comment
isra-fel
left a comment
There was a problem hiding this comment.
Hello @gautam714 , could you
- Update this PR to include a link to the orginal spec review PR
- Add the
.txtfile generated when you rungenerate.ps1here - Update versions, tags, if necessary
- Fix the conflicts
Thanks
Contributor
Author
added 7 commits
August 28, 2019 10:30
…nto master-renewalchanges
…nto master-renewalchanges
Member
|
All manangement checks have passed, besides the client mac and windows checks passed too, I'll merge this PR. |
isra-fel
approved these changes
Aug 29, 2019
JoshLove-msft
added a commit
to JoshLove-msft/azure-sdk-for-net
that referenced
this pull request
Aug 30, 2019
Task 5207653: RI renewal: Dot net sdk changes. (Azure#7386)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.