[Compute] Upgrading the diskrp sdk to use version 2019-03-01#7363
Merged
isra-fel merged 4 commits intoAzure:masterfrom Aug 23, 2019
Merged
[Compute] Upgrading the diskrp sdk to use version 2019-03-01#7363isra-fel merged 4 commits intoAzure:masterfrom
isra-fel merged 4 commits intoAzure:masterfrom
Conversation
realschwa
changed the title
Member
|
Looks good to me. Just please fix the CI issue. |
isra-fel
added
Mgmt
Contributor
Author
|
@isra-fel the CI tests now pass |
vikramd-ms
reviewed
Aug 22, 2019
| /// unique id identifying the source of this resource.</param> | ||
| /// <param name="uploadSizeBytes">If createOption is Upload, this is | ||
| /// the size of the contents of the upload including the VHD footer. | ||
| /// This value should be between 1073741824 (1 GiB + 512 bytes for the |
There was a problem hiding this comment.
This does not look correct. We should be allowing disks of size > 10 MB or so. Please check.
Contributor
Author
There was a problem hiding this comment.
I thought empty disks and upload disks have a minimum of 1gb?
Contributor
Author
There was a problem hiding this comment.
PR to fix the description:
Azure/azure-rest-api-specs#7025
realschwa
changed the title
realschwa
changed the title
Contributor
Author
|
@isra-fel All good to merge now once the CI tests pass |
isra-fel
approved these changes
Aug 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completed Swagger PR Azure/azure-rest-api-specs#6824