Conversation
isra-fel
left a comment
isra-fel
left a comment
There was a problem hiding this comment.
Hi @visharm , please follow these instructions, and make sure that:
- The
eng\mgmt\mgmtmetadata\<rpName>.txtfile is included in this PR - Versions have been updated, if necessary
- Package tags, release notes, have been updated
And please put a link to the corresponding swagger review PR in comments. Thanks
| <![CDATA[ | ||
| - Bug fix for updating Logic Apps that have an attached Integration Account | ||
| - Added WorkflowRunActionRequestHistories, WorkflowRunActionRepetitionsRequestHistories | ||
| - Added Integration Service Environment reference in Workflow |
There was a problem hiding this comment.
I think you'd better remove the notes from last release
There was a problem hiding this comment.
And please also update <Version> in this file
| [assembly: AssemblyProduct("Azure .NET SDK")] | ||
| [assembly: AssemblyVersion("4.1.0.0")] | ||
| [assembly: AssemblyVersion("4.2.0.0")] | ||
| [assembly: AssemblyFileVersion("4.0.0.0")] |
There was a problem hiding this comment.
AssemblyFileVersion should be updated
There was a problem hiding this comment.
Could you please take a look at the CR?
|
@visharm , you are making a big change and updating API versions, so please
Please also fix test errors -- they are mainly caused by the change of the API |
|
Hello @visharm any update? |
|
Closing this for now @visharm, feel free to reopen to continue, thanks |
2 participants
No description provided.