Generated code for 2019-07-01 version of Microsoft.Resources swagger.#7177
Merged
erich-wang merged 3 commits intoAzure:masterfrom Aug 8, 2019
Merged
Generated code for 2019-07-01 version of Microsoft.Resources swagger.#7177erich-wang merged 3 commits intoAzure:masterfrom
erich-wang merged 3 commits intoAzure:masterfrom
Conversation
Contributor
Author
|
The swagger PR: Azure/azure-rest-api-specs#6720 |
erich-wang
suggested changes
Aug 7, 2019
Member
erich-wang
left a comment
erich-wang
left a comment
There was a problem hiding this comment.
@Tiano2017 , could you follow the instruction to complete all steps?
| <None Update="ScenarioTests\management_group_level_template.json"> | ||
| <CopyToOutputDirectory>Always</CopyToOutputDirectory> | ||
| </None> | ||
| <None Update="ScenarioTests\tenant_level_template.json"> |
Member
There was a problem hiding this comment.
Could we use Update="ScenarioTests\**\*.json" instead to avoid list all json files here?
| <!--This file and it's contents are updated at build time moving or editing might result in build failure. Take due deligence while editing this file--> | ||
| <PropertyGroup> | ||
| <AzureApiTag /> | ||
| <AzureApiTag>Attestation_2018-09-01-preview;</AzureApiTag> |
Member
There was a problem hiding this comment.
Any particular reason to include the change in this Microsoft.ResourceManager related PR?
Contributor
Author
There was a problem hiding this comment.
Not sure how did they changes get here. Will revert.
| <!--This file and it's contents are updated at build time moving or editing might result in build failure. Take due deligence while editing this file--> | ||
| <PropertyGroup> | ||
| <AzureApiTag>Fabric.Admin_2018-10-01;Fabric.Admin_2016-05-01;</AzureApiTag> | ||
| <AzureApiTag>Fabric.Admin_2016-05-01;</AzureApiTag> |
| <!--This file and it's contents are updated at build time moving or editing might result in build failure. Take due deligence while editing this file--> | ||
| <PropertyGroup> | ||
| <AzureApiTag>Compute_2019-03-01;Compute_2018-09-30;Compute_2019-04-01;ContainerService_2017-01-31;</AzureApiTag> | ||
| <AzureApiTag>Compute_2019-03-01;Compute_2018-09-30;Compute_2019-07-01;Compute_2019-04-01;ContainerService_2017-01-31;</AzureApiTag> |
Contributor
Author
|
@erich-wang Thanks for reviewing. I've pushed a few changes. The only thing missing is the "generate.ps1" for resources sdk doesn't work. I had to run the AutoRest command manually. |
erich-wang
approved these changes
Aug 8, 2019
pull bot
pushed a commit
to test-repo-billy/azure-sdk-for-net
that referenced
this pull request
Aug 8, 2019
…Azure#7177) * Generated code for 2019-07-01 version of Microsoft.Resources swagger. * Fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.