Adding units to the Metrics API, adding one attribute to the DiagnosticSettings API, updating documentation#7074
Conversation
| @@ -0,0 +1,12 @@ | |||
| 2019-08-01 03:08:36 UTC | |||
There was a problem hiding this comment.
@gucalder, this file should be under eng\mgmt\mgmtmetadata
There was a problem hiding this comment.
Ok, moving the file.
BTW: this file was created automatically. There has to be some kind of bug or I am running the wrong command to generate the code.
There was a problem hiding this comment.
@gucalder , you need to first pull latest code from master, then follow the step 2 https://github.com/Azure/adx-documentation-pr/blob/master/engineering/adx_netsdk_process.md#sdk-generation-from-updated-spec
msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules
|
Ping |
|
@gucalder , overall LGTM, could you provide the swagger spec PR link related to this PR? I need to confirm whether the spec is merged? |
|
These are the links to the PRs for the last specs changes: These have not been generated before since there was some kind of issue with the automatic generation of code, and when I tried manually, there were some bugs in the autorest library that made it fail. |
|
Ping |
3 participants
Adding some metric unit names to the Metrics API 2018-01-01. The complete list now includes the following: "Count", "Bytes", "Seconds", "CountPerSecond", "BytesPerSecond", "Percent", "MilliSeconds", "ByteSeconds", "Unspecified", "Cores", "MilliCores", "NanoCores", "BitsPerSecond"
Adding support for a new attribute in the DiagnosticSettings object (Diagnostic Settings API 2017-05-01-preview,) i.e.: the attribute is "logAnalyticsDestinationType," which is a string that accepts the following values: Dedicated or null
Minor modification to the documentation