[SignalR] Update .net SDK for swagger PR 5661 #6610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@erich-wang will be reviewing your PR. |
Member
|
@shahabhijeet , this PR looks fine to me, I'm going to approve the PR tomorrow if you don't have any other comments. |
erich-wang
changed the title
erich-wang
suggested changes
Jun 21, 2019
Member
erich-wang
left a comment
erich-wang
left a comment
There was a problem hiding this comment.
@juniwang , it seems you need to upgrade nuget package version as well because of new APIs, how about include the changes in this PR as well?
erich-wang
approved these changes
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's for Swagger PR 5661: Azure/azure-rest-api-specs#5661. The original auto-PR wasn't completed due to structural change of the repo.
Codes are auto-generated by
tools\generated.cmd signalr/resource-managerwhich is almost the same as the auto PR(#5823).