[FaceAPI] Add detection model parameter#6522
Conversation
|
@lebronJ =) |
|
|
It seems like our AssemblyInfo.cs file was deleted here: 4ac320b#diff-249b622914167b32cea7bd2da775f910 Is this expected? |
|
@dsgouda, @shahabhijeet We met some problems when generating .NET SDKs based on latest swagger file from Azure/azure-rest-api-specs#6214. Seems the folder structure has been adjusted since our last changes, could anyone help figure out the current right way to generate .NET SDK for Face API? Local error messages when running the Resolve-Path : Cannot find path 'C:\Users\siqliu\Documents\WindowsPowerShell\Modules\CodeGenerationModules\SDKs'
Installing AutoRest version: latest
E:\nodejs\autorest -> E:\nodejs\node_modules\autorest\dist\app.js AutoRest installed successfully. Write-ErrorLog : Error: Unable to start AutoRest Core from
Write-ErrorLog : System.Management.Automation.RuntimeException: Cannot convert value to type System.String. --->
Write-ErrorLog : AutoRest code generation for
Write-ErrorLog : AutoRest code generation for
|
|
Moreover, will .NET SDK be generated by auto PR from Swagger PR, or be generated by ourselves locally by the I believe all generated SDKs in this PR are generated by local auto-rest commands, not through |
|
@chidozieononiwu could you take a look since you worked on migrating the directory structure. |
Yes, Assembly Information is now generated from the csproj file. |
545ccef to
dc09146
Compare
dc09146 to
bfe182c
Compare
|
@dsgouda @chidozieononiwu this PR is ready for a merge =) |
|
@dsgouda, @chidozieononiwu , @shahabhijeet , Can you please help review nad merge this PR? |
| <AssemblyTitle>Microsoft Cognitive Services Face SDK</AssemblyTitle> | ||
| <Description>This client library provides access to the Microsoft Cognitive Services Face APIs.</Description> | ||
| <VersionPrefix>2.4.0</VersionPrefix> | ||
| <VersionPrefix>2.5.0-preview</VersionPrefix> |
There was a problem hiding this comment.
This should only be set to 2.5.0 without the "-preview" as that gets set when producing the build. See https://github.com/Azure/azure-sdk-for-net/blob/master/Documentation/Versioning.md.
Auto-regenerated the Face-API SDK from the latest swagger.
All tests run green. However, since the project restructure, they are only running green when ran by sub-section. Running them all will make them fail. I am not sure why this is