Skip to content

fixed genrate.ps1 and generat.cmd paths#6328

Merged
dsgouda merged 1 commit into
Azure:masterfrom
chidozieononiwu:UpdateGenerated.cmdPath
May 21, 2019
Merged

fixed genrate.ps1 and generat.cmd paths#6328
dsgouda merged 1 commit into
Azure:masterfrom
chidozieononiwu:UpdateGenerated.cmdPath

Conversation

@chidozieononiwu
Copy link
Copy Markdown
Member

@chidozieononiwu chidozieononiwu commented May 18, 2019

No description provided.

@chidozieononiwu
Copy link
Copy Markdown
Member Author

chidozieononiwu commented May 20, 2019

@Azure/azure-sdk-eng

@weshaggard
Copy link
Copy Markdown
Member

weshaggard commented May 20, 2019

@shahabhijeet are these scripts even used now after the automation has been setup from the specs repo?

dsgouda
dsgouda suggested changes May 20, 2019
View reviewed changes
Comment thread sdk/hdinsight/Microsoft.Azure.HDInsight.Job/src/generate.ps1 Outdated
Copy link
Copy Markdown
Contributor

@dsgouda dsgouda May 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the intent behind these changes? -ResourceProvider corresponds to the relative path to specifications folder in REST specs repo. The paths being introduced here don't even exist

Copy link
Copy Markdown
Member Author

@chidozieononiwu chidozieononiwu May 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you mean, I have removed those changes from the PR. It seems the .cmd files need to be updated still?

@dsgouda
Copy link
Copy Markdown
Contributor

dsgouda commented May 20, 2019

@weshaggard even if automation exists, these scripts are used if RPs wish to manually generate the SDK and open a PR
Also, while @chidozieononiwu was working on modifying the repo structure we disabled PR automation for NET SDK since this involves updating path references in our DB.

@chidozieononiwu chidozieononiwu force-pushed the UpdateGenerated.cmdPath branch from 8b8a052 to 1bce8da Compare May 20, 2019 23:19
dsgouda
dsgouda approved these changes May 21, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I have assumed you have tested these scripts

@dsgouda
Copy link
Copy Markdown
Contributor

dsgouda commented May 21, 2019

/azp run azure-sdk-for-net - mgmt

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented May 21, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@dsgouda dsgouda merged commit b1c5d7e into Azure:master May 21, 2019
@chidozieononiwu chidozieononiwu deleted the UpdateGenerated.cmdPath branch May 21, 2019 19:23
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
@chidozieononiwu @mentat9
Updated path in cmd (Azure#6328)
db3d10b
@snyk-io snyk-io Bot mentioned this pull request Oct 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weshaggard weshaggard weshaggard approved these changes

+1 more reviewer

@dsgouda dsgouda dsgouda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chidozieononiwu @weshaggard @dsgouda