Skip to content

[docs] AppConfig README #6192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
KrzysztofCwalina merged 2 commits into from
May 17, 2019
Merged

[docs] AppConfig README #6192

KrzysztofCwalina merged 2 commits into from
May 17, 2019

Conversation

@mmacy
Copy link
Contributor

@mmacy mmacy commented May 8, 2019

  • Fix links in intro
  • Bulleted feature/operation list in intro and simplify to adhere more closely to README template format
  • Markdownlint accommodations (mostly spacing)
  • Remove /en-us/ locale identifier from docs.microsoft.com URLs to allow browser redirect in non-US locales

@mmacy
Copy link
Contributor Author

mmacy commented May 9, 2019

@scbedd Hey Scott, is this something you can review?

@scbedd scbedd mentioned this pull request May 9, 2019
Merged
scbedd
scbedd approved these changes May 10, 2019
View reviewed changes
Copy link
Member

@scbedd scbedd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read through, confirmed all the links resolve, content makes sense to me.

I'm not an owner on AppConfiguration though. I added @maririos directly to the PR as she's been through here recently.

@scbedd scbedd requested a review from maririos May 10, 2019 21:35
maririos
maririos approved these changes May 13, 2019
View reviewed changes
Copy link
Member

@maririos maririos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ mmacy !!

@KrzysztofCwalina KrzysztofCwalina merged commit fe95c39 into Azure:master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KrzysztofCwalina KrzysztofCwalina KrzysztofCwalina approved these changes

@maririos maririos maririos approved these changes

@scbedd scbedd scbedd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mmacy @KrzysztofCwalina @maririos @scbedd