Skip to content

[DevSpaces] 2019-04-01 API version update #5966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sanar-microsoft wants to merge 1 commit into from
Closed

[DevSpaces] 2019-04-01 API version update #5966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/SDKs/DevSpaces/Management.DevSpaces/Microsoft.Azure.Management.DevSpaces.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@
<PropertyGroup>
<PackageId>Microsoft.Azure.Management.DevSpaces</PackageId>
<Description>Provides management operations support for Azure Dev Spaces.</Description>
<Version>0.11.0-preview</Version>
<Version>1.0.0</Version>
Copy link
Copy Markdown
Contributor

@dsgouda dsgouda Apr 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sanar-microsoft Just to confirm you wish to release a new version of the rest api with a stable Nuget package. We usually recommend Nuget versions to be preview for a first few versions before marking it as stable since we cannot accept breaking changes for a stable version

Copy link
Copy Markdown
Member Author

@sanar-microsoft sanar-microsoft Apr 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll hold off on merging this then. I think we might want to change the validation rule for our resource name before releasing the stable version. I'll update this PR when the swagger changes are in.

Thanks for the heads up.

Copy link
Copy Markdown
Contributor

@dsgouda dsgouda Apr 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sanar-microsoft you can still release this as a preview if you wish. Alternatively, please close this PR and open a new PR when you are ready to publish the stable version

<AssemblyName>Microsoft.Azure.Management.DevSpaces</AssemblyName>
<PackageTags>Microsoft Azure Dev Spaces;Dev Spaces;</PackageTags>
<PackageReleaseNotes>
<![CDATA[
1) Added support for API version 2019-01-01-preview.
1) Added support for API version 2019-04-01.
]]>
</PackageReleaseNotes>
</PropertyGroup>
Expand Down
4 changes: 2 additions & 2 deletions src/SDKs/DevSpaces/Management.DevSpaces/Properties/AssemblyInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
[assembly: AssemblyTitle("Microsoft Azure Dev Spaces Management Library")]
[assembly: AssemblyDescription("Provides management operations support for Azure Dev Spaces.")]

[assembly: AssemblyVersion("0.11.0.0")]
[assembly: AssemblyFileVersion("0.11.0.0")]
[assembly: AssemblyVersion("1.0.0.0")]
[assembly: AssemblyFileVersion("1.0.0.0")]

[assembly: AssemblyConfiguration("")]
[assembly: AssemblyCompany("Microsoft")]
Expand Down