Skip to content

Comments

Reservations SDK with tests updated#5874

Merged
dsgouda merged 4 commits intoAzure:masterfrom
corquiri:reservation20190401
Apr 23, 2019
Merged

Reservations SDK with tests updated#5874
dsgouda merged 4 commits intoAzure:masterfrom
corquiri:reservation20190401

Conversation

@corquiri
Copy link
Contributor

Most recent .Net SDK already merged to master. This PR is to fix failing test. I verified that both below works:

msbuild build.proj /t:Build /p:Scope=SDKs\Reservations
msbuild build.proj /t:RunTests /p:Scope=SDKs\Reservations

@corquiri
Copy link
Contributor Author

I also need to publish this package to NuGet, please let me know if I have all the requirement ready.

@corquiri
Copy link
Contributor Author

netcore build failed with error:
The command "sudo apt-get update" failed and exited with 100 during .
Could someone help me why I am getting this error?

@dsgouda
Copy link
Contributor

dsgouda commented Apr 22, 2019

netcore build failed with error:
The command "sudo apt-get update" failed and exited with 100 during .
Could someone help me why I am getting this error?

We are working on fixing it, should be unrelated to this change

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming tests fixed here
@corquiri Please update the Assembly Version and PackageReleaseNotes in csproj/AssemblyInfo.cs files if you wish to publish a Nuget for this

@dsgouda
Copy link
Contributor

dsgouda commented Apr 22, 2019

@corquiri Please pull from latest master and update the PR to fix the Travis failures

@corquiri
Copy link
Contributor Author

@dsgouda I have pulled latest master and bumped up the version. Could you please review and merge this request?

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 1a00651 into Azure:master Apr 23, 2019
@dsgouda
Copy link
Contributor

dsgouda commented Apr 23, 2019

@corquiri Tests are still failing here
PTAL and fix them

@corquiri
Copy link
Contributor Author

That failure was introduced by PR : #5889
Which is separate task from this PR. @gautam714 will be working on fixing test.

mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
* Test updated

* bumping up version

* correcting version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants