Skip to content

Hyak net core add release notes and deprecated some method #5764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shahabhijeet merged 3 commits into from
Apr 11, 2019
Merged

Hyak net core add release notes and deprecated some method #5764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c204128
ADD three api, GetGatewaySettings, UpdateGatewaySettings, ListConfigu…
Apr 1, 2019
987a5f9
Add release notes, and add Obselete annotaiton
Apr 11, 2019
00830af
Merge branch 'HyakNETCore' of https://github.com/Azure/azure-sdk-for-…
Apr 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/ResourceManagement/HDInsight/HDInsight.Tests/ScenarioTests/CreateClusterTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
// limitations under the License.
//

using System;
using System.Net;
using HDInsight.Tests.Helpers;
using Hyak.Common;
Expand Down Expand Up @@ -188,6 +189,7 @@ public void TestCreateDuplicateCluster()
}

[Fact(Skip = "This test case will be skipped.")]
[Obsolete]
public void TestCustomCreateEnableDisableConnectivity()
{
var handler = new RecordedDelegatingHandler { StatusCodeToReturn = HttpStatusCode.OK };
Expand Down
25 changes: 17 additions & 8 deletions ...re.Management.HDInsight/Customizations/ClusterOperationsExtensions.Http.Customizations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
// limitations under the License.
//

using System;
using System.Threading;
using System.Threading.Tasks;
using Microsoft.Azure.Management.HDInsight.Models;
Expand All @@ -26,7 +27,7 @@ namespace Microsoft.Azure.Management.HDInsight
public static partial class ClusterOperationsExtensions
{
/// <summary>
/// Enables HTTP on the specified cluster.
/// This method has been deprecated and will stop working. Enables HTTP on the specified cluster.
/// </summary>
/// <param name='operations'>
/// Reference to the
Expand All @@ -47,6 +48,7 @@ public static partial class ClusterOperationsExtensions
/// <returns>
/// The cluster long running operation response.
/// </returns>
[Obsolete("This method has been deprecated and will stop working.")]
public static OperationResource EnableHttp(this IClusterOperations operations,
string resourceGroupName, string clusterName, string username, string password)
{
Expand All @@ -61,7 +63,7 @@ public static OperationResource EnableHttp(this IClusterOperations operations,
}

/// <summary>
/// Enables HTTP on the specified cluster.
/// This method has been deprecated and will stop working. Enables HTTP on the specified cluster.
/// </summary>
/// <param name='operations'>
/// Reference to the
Expand All @@ -82,14 +84,15 @@ public static OperationResource EnableHttp(this IClusterOperations operations,
/// <returns>
/// The cluster long running operation response.
/// </returns>
[Obsolete("This method has been deprecated and will stop working.")]
public static Task<OperationResource> EnableHttpAsync(this IClusterOperations operations,
string resourceGroupName, string clusterName, string username, string password)
{
return operations.EnableHttpAsync(resourceGroupName, clusterName, username, password, CancellationToken.None);
}

/// <summary>
/// Begins enabling HTTP on the specified cluster.
/// This method has been deprecated and will stop working. Begins enabling HTTP on the specified cluster.
/// </summary>
/// <param name='operations'>
/// Reference to the
Expand All @@ -110,6 +113,7 @@ public static Task<OperationResource> EnableHttpAsync(this IClusterOperations op
/// <returns>
/// The cluster long running operation response.
/// </returns>
[Obsolete("This method has been deprecated and will stop working.")]
public static HDInsightOperationResponse BeginEnablingHttp(this IClusterOperations operations,
string resourceGroupName, string clusterName, string username, string password)
{
Expand All @@ -122,7 +126,7 @@ public static HDInsightOperationResponse BeginEnablingHttp(this IClusterOperatio
}

/// <summary>
/// Begins enabling HTTP on the specified cluster.
/// This method has been deprecated and will stop working. Begins enabling HTTP on the specified cluster.
/// </summary>
/// <param name='operations'>
/// Reference to the
Expand All @@ -143,6 +147,7 @@ public static HDInsightOperationResponse BeginEnablingHttp(this IClusterOperatio
/// <returns>
/// The cluster long running operation response.
/// </returns>
[Obsolete("This method has been deprecated and will stop working.")]
public static Task<HDInsightOperationResponse> BeginEnablingHttpAsync(this IClusterOperations operations,
string resourceGroupName, string clusterName, string username, string password)
{
Expand All @@ -151,7 +156,7 @@ public static Task<HDInsightOperationResponse> BeginEnablingHttpAsync(this IClus
}

/// <summary>
/// Disables HTTP on the specified cluster.
/// This method has been deprecated and will stop working. Disables HTTP on the specified cluster.
/// </summary>
/// <param name='operations'>
/// Reference to the
Expand All @@ -166,6 +171,7 @@ public static Task<HDInsightOperationResponse> BeginEnablingHttpAsync(this IClus
/// <returns>
/// The cluster long running operation response.
/// </returns>
[Obsolete("This method has been deprecated and will stop working.")]
public static OperationResource DisableHttp(this IClusterOperations operations,
string resourceGroupName, string clusterName)
{
Expand All @@ -179,7 +185,7 @@ public static OperationResource DisableHttp(this IClusterOperations operations,
}

/// <summary>
/// Disables HTTP on the specified cluster.
/// This method has been deprecated and will stop working. Disables HTTP on the specified cluster.
/// </summary>
/// <param name='operations'>
/// Reference to the
Expand All @@ -194,14 +200,15 @@ public static OperationResource DisableHttp(this IClusterOperations operations,
/// <returns>
/// The cluster long running operation response.
/// </returns>
[Obsolete("This method has been deprecated and will stop working.")]
public static Task<OperationResource> DisableHttpAsync(this IClusterOperations operations,
string resourceGroupName, string clusterName)
{
return operations.DisableHttpAsync(resourceGroupName, clusterName, CancellationToken.None);
}

/// <summary>
/// Begins disabling HTTP on the specified cluster.
/// This method has been deprecated and will stop working. Begins disabling HTTP on the specified cluster.
/// </summary>
/// <param name='operations'>
/// Reference to the
Expand All @@ -216,6 +223,7 @@ public static Task<OperationResource> DisableHttpAsync(this IClusterOperations o
/// <returns>
/// The cluster long running operation response.
/// </returns>
[Obsolete("This method has been deprecated and will stop working.")]
public static HDInsightOperationResponse BeginDisablingHttp(this IClusterOperations operations,
string resourceGroupName, string clusterName)
{
Expand All @@ -229,7 +237,7 @@ public static HDInsightOperationResponse BeginDisablingHttp(this IClusterOperati
}

/// <summary>
/// Begins disabling HTTP on the specified cluster.
/// This method has been deprecated and will stop working. Begins disabling HTTP on the specified cluster.
/// </summary>
/// <param name='operations'>
/// Reference to the
Expand All @@ -244,6 +252,7 @@ public static HDInsightOperationResponse BeginDisablingHttp(this IClusterOperati
/// <returns>
/// The cluster long running operation response.
/// </returns>
[Obsolete("This method has been deprecated and will stop working.")]
public static Task<HDInsightOperationResponse> BeginDisablingHttpAsync(this IClusterOperations operations,
string resourceGroupName, string clusterName)
{
Expand Down
12 changes: 8 additions & 4 deletions .../Microsoft.Azure.Management.HDInsight/Customizations/IClusterOperations.Customizations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ public partial interface IClusterOperations
Task<ClusterCreateResponse> BeginCreatingAsync(string resourceGroupName, string clusterName, ClusterCreateParameters clusterCreateParameters, CancellationToken cancellationToken);

/// <summary>
/// Enables HTTP on the specified cluster.
/// This method has been deprecated and will stop working. Enables HTTP on the specified cluster.
/// </summary>
/// <param name='resourceGroupName'>
/// Required. The name of the resource group.
Expand All @@ -88,11 +88,12 @@ public partial interface IClusterOperations
/// <returns>
/// The cluster long running operation response.
/// </returns>
[Obsolete("This method has been deprecated and will stop working.")]
Task<OperationResource> EnableHttpAsync(string resourceGroupName, string clusterName,
string username, string password, CancellationToken cancellationToken);

/// <summary>
/// Begins enabling HTTP on the specified cluster.
/// This method has been deprecated and will stop working. Begins enabling HTTP on the specified cluster.
/// </summary>
/// <param name='resourceGroupName'>
/// Required. The name of the resource group.
Expand All @@ -112,11 +113,12 @@ Task<OperationResource> EnableHttpAsync(string resourceGroupName, string cluster
/// <returns>
/// The cluster long running operation response.
/// </returns>
[Obsolete("This method has been deprecated and will stop working.")]
Task<HDInsightOperationResponse> BeginEnablingHttpAsync(string resourceGroupName, string clusterName,
string username, string password, CancellationToken cancellationToken);

/// <summary>
/// Disables HTTP on the specified cluster.
/// This method has been deprecated and will stop working. Disables HTTP on the specified cluster.
/// </summary>
/// <param name='resourceGroupName'>
/// Required. The name of the resource group.
Expand All @@ -130,10 +132,11 @@ Task<HDInsightOperationResponse> BeginEnablingHttpAsync(string resourceGroupName
/// <returns>
/// The cluster long running operation response.
/// </returns>
[Obsolete("This method has been deprecated and will stop working.")]
Task<OperationResource> DisableHttpAsync(string resourceGroupName, string clusterName, CancellationToken cancellationToken);

/// <summary>
/// Begins disabling HTTP on the specified cluster.
/// This method has been deprecated and will stop working. Begins disabling HTTP on the specified cluster.
/// </summary>
/// <param name='resourceGroupName'>
/// Required. The name of the resource group.
Expand All @@ -147,6 +150,7 @@ Task<HDInsightOperationResponse> BeginEnablingHttpAsync(string resourceGroupName
/// <returns>
/// The cluster long running operation response.
/// </returns>
[Obsolete("This method has been deprecated and will stop working.")]
Task<HDInsightOperationResponse> BeginDisablingHttpAsync(string resourceGroupName, string clusterName, CancellationToken cancellationToken);

/// <summary>
Expand Down
10 changes: 9 additions & 1 deletion ...urceManagement/HDInsight/Microsoft.Azure.Management.HDInsight/Management.HDInsight.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,15 @@
<PackageTags>Microsoft Azure HDInsight Management;HDInsight;HDInsight Management</PackageTags>
<PackageReleaseNotes>
<![CDATA[
This is a public preview release of the Azure HDInsight SDK. Add support for get/update gatewaysettings.
This release contains some important changes to allow for more fine-grained role-based access to obtain sensitive credentials. As part of these changes, ACTION MAY BE REQUIRED if you are using one of the affected methods:
1) ClusterOperationsExtensions.GetClusterConfigurations will NO LONGER RETURN SENSITIVE PARAMETERS like storage keys (core-site) or HTTP credentials (gateway).
- To retrieve all configurations, including sensitive parameters, use ClusterOperationsExtensions.ListConfigurations going forward.  Not that users with the 'Reader' role will not be able to use this method to allow for fine-grained control over which users can access cluster secrets.
- To retrieve just HTTP gateway credentials, use ClusterOperationsExtensions.GetGatewaySettings.
2) ClusterOperationsExtensions.GetConnectivitySettings is now deprecated and has been replaced by ClusterOperationsExtensions.GetGatewaySettings.
3) ClusterOperationsExtensions.ConfigureHttpSettings is now deprecated and has been replaced by ClusterOperationsExtensions.UpdateGatewaySettings.
4) ConfigurationsOperationsExtensions.EnableHttp and DisableHttp are now deprecated. Http is now always enabled, so these methods are no longer needed.

For more information, please visit https://aka.ms/hdi-config-update
]]>
</PackageReleaseNotes>
<SignAssembly>true</SignAssembly>
Expand Down