Skip to content

Rename EnablePerfCounters to EnablePerformanceCounters per API review#57561

Merged
harsimar merged 1 commit intoAzure:mainfrom
harsimar:harskaur/apiChangeEnablePerformanceCounters
Mar 28, 2026
Merged

Rename EnablePerfCounters to EnablePerformanceCounters per API review#57561
harsimar merged 1 commit intoAzure:mainfrom
harsimar:harskaur/apiChangeEnablePerformanceCounters

Conversation

@harsimar
Copy link
Copy Markdown
Member

Renamed across Exporter and AspNetCore source, tests, API listings, and changelogs.

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

Renamed across Exporter and AspNetCore source, tests, API listings, and changelogs.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 27, 2026 23:23
@github-actions github-actions bot added Monitor - Distro Monitor OpenTelemetry Distro Monitor - Exporter Monitor OpenTelemetry Exporter labels Mar 27, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR renames the public option EnablePerfCounters to EnablePerformanceCounters across Azure Monitor OpenTelemetry Exporter and ASP.NET Core distro to align with the API review naming.

Changes:

  • Renamed the options property and updated internal usage (StandardMetricsExtractionProcessor) and unit tests.
  • Updated public API listings for all target frameworks.
  • Updated changelog text to reflect the renamed option.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/tests/Azure.Monitor.OpenTelemetry.Exporter.Tests/StandardMetricTests.cs Updates tests to use EnablePerformanceCounters.
sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Internals/StandardMetricsExtractionProcessor.cs Renames internal flag and adjusts conditional logic accordingly.
sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/AzureMonitorExporterOptions.cs Renames the public exporter option property.
sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/api/Azure.Monitor.OpenTelemetry.Exporter.netstandard2.0.cs Updates exporter API surface to new property name.
sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/api/Azure.Monitor.OpenTelemetry.Exporter.net8.0.cs Updates exporter API surface to new property name.
sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/api/Azure.Monitor.OpenTelemetry.Exporter.net10.0.cs Updates exporter API surface to new property name.
sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/CHANGELOG.md Updates changelog mention of the option name.
sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/tests/Azure.Monitor.OpenTelemetry.AspNetCore.Tests/AzureMonitorOptionsTests.cs Updates distro tests to use EnablePerformanceCounters.
sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/AzureMonitorOptions.cs Renames the public distro option property and propagation into exporter options.
sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/api/Azure.Monitor.OpenTelemetry.AspNetCore.netstandard2.0.cs Updates distro API surface to new property name.
sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/api/Azure.Monitor.OpenTelemetry.AspNetCore.net8.0.cs Updates distro API surface to new property name.
sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/api/Azure.Monitor.OpenTelemetry.AspNetCore.net10.0.cs Updates distro API surface to new property name.
sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/CHANGELOG.md Updates changelog mention of the option name.

@harsimar harsimar merged commit 55e7b4e into Azure:main Mar 28, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Monitor - Distro Monitor OpenTelemetry Distro Monitor - Exporter Monitor OpenTelemetry Exporter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants