Rename EnablePerfCounters to EnablePerformanceCounters per API review#57561
Merged
harsimar merged 1 commit intoAzure:mainfrom Mar 28, 2026
Merged
Conversation
Renamed across Exporter and AspNetCore source, tests, API listings, and changelogs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rajkumar-rangaraj
approved these changes
Mar 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR renames the public option EnablePerfCounters to EnablePerformanceCounters across Azure Monitor OpenTelemetry Exporter and ASP.NET Core distro to align with the API review naming.
Changes:
- Renamed the options property and updated internal usage (
StandardMetricsExtractionProcessor) and unit tests. - Updated public API listings for all target frameworks.
- Updated changelog text to reflect the renamed option.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/tests/Azure.Monitor.OpenTelemetry.Exporter.Tests/StandardMetricTests.cs | Updates tests to use EnablePerformanceCounters. |
| sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Internals/StandardMetricsExtractionProcessor.cs | Renames internal flag and adjusts conditional logic accordingly. |
| sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/AzureMonitorExporterOptions.cs | Renames the public exporter option property. |
| sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/api/Azure.Monitor.OpenTelemetry.Exporter.netstandard2.0.cs | Updates exporter API surface to new property name. |
| sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/api/Azure.Monitor.OpenTelemetry.Exporter.net8.0.cs | Updates exporter API surface to new property name. |
| sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/api/Azure.Monitor.OpenTelemetry.Exporter.net10.0.cs | Updates exporter API surface to new property name. |
| sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/CHANGELOG.md | Updates changelog mention of the option name. |
| sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/tests/Azure.Monitor.OpenTelemetry.AspNetCore.Tests/AzureMonitorOptionsTests.cs | Updates distro tests to use EnablePerformanceCounters. |
| sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/AzureMonitorOptions.cs | Renames the public distro option property and propagation into exporter options. |
| sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/api/Azure.Monitor.OpenTelemetry.AspNetCore.netstandard2.0.cs | Updates distro API surface to new property name. |
| sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/api/Azure.Monitor.OpenTelemetry.AspNetCore.net8.0.cs | Updates distro API surface to new property name. |
| sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/api/Azure.Monitor.OpenTelemetry.AspNetCore.net10.0.cs | Updates distro API surface to new property name. |
| sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/CHANGELOG.md | Updates changelog mention of the option name. |
sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/AzureMonitorExporterOptions.cs
Show resolved
Hide resolved
sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/AzureMonitorOptions.cs
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed across Exporter and AspNetCore source, tests, API listings, and changelogs.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.